From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 207DC2C0C for ; Tue, 2 Oct 2018 13:38:12 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id AD7E921ED6; Tue, 2 Oct 2018 07:38:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Tue, 02 Oct 2018 07:38:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ha4ZpftGfuWcHHlwHcrzLUXs0u IDX05B3xKlq24M2XE=; b=jH4uMyigfETkq7yBRagAr7LMrluW/Xzhx2JcTpxkiQ 8AmqaFfErVp/FMjT1uqwey9Q0Yjls1BZA3WUkx0/NNqA14Ey4lyi0WMbKLSBDBv5 QMyn4mWQS65z/J2hnLrFzCCZrbNUeDvTpkDKIU76HNcH7Jv1X3DMUag3LE2NcmD5 c= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=ha4Zpf tGfuWcHHlwHcrzLUXs0uIDX05B3xKlq24M2XE=; b=rhNuZPrMo+r4S0bL17Kuju xfXkdobke9f3TvQk+D6hGyJZJvqXvvCojMCMLHETyEK/g2FPkwQEyJsaZHou9XQU jmNL+srFAtau3//8sqd7y5VuCCXodCBTJufNsMX6dZvLi0e6fu8ZxsBW7mxVVIS5 WZOwh/DC9zj7dBolIImH+9GT+2GW1OgBF567zS4ja/FRSnrLTcNeoJUT5IJbXJ68 GeUciofL014z1ESjFhs4+d4Gys0yCyrVsdb4gyQBID7wDKcyNxChsRS+duPgxnAN 84nTQMYAwUcWUU4YCUpEiD52U+H3V6NUMyVOj1+o5PYtCtfMx8JFi8X1mmtQa8zg == X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 0E4D2102EA; Tue, 2 Oct 2018 07:38:09 -0400 (EDT) From: Thomas Monjalon To: Raslan Darawsheh Cc: "dev@dpdk.org" , "keith.wiles@intel.com" , Shahaf Shuler , Ori Kam , ferruh.yigit@intel.com Date: Tue, 02 Oct 2018 13:38:09 +0200 Message-ID: <1606810.hPqmbmdGoK@xps> In-Reply-To: References: <1538047196-13789-2-git-send-email-rasland@mellanox.com> <2772955.aHLSG1IVkg@xps> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v4 2/2] net/tap: add queues when attaching from secondary process X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 02 Oct 2018 11:38:12 -0000 02/10/2018 12:50, Raslan Darawsheh: > From: Thomas Monjalon > > 02/10/2018 12:34, Raslan Darawsheh: > > > @@ -2056,6 +2179,13 @@ rte_pmd_tap_probe(struct rte_vdev_device *dev) > > > > > > TAP_LOG(NOTICE, "Initializing pmd_tap for %s as %s", > > > > > > name, tap_name); > > > > > > + /* Register IPC feed callback */ > > > + ret = rte_mp_action_register(TAP_MP_KEY, tap_mp_sync_queues); > > > + if (ret < 0 && rte_errno != EEXIST) { > > > + TAP_LOG(ERR, "%s: Failed to register IPC callback: %s", > > > + tuntap_name, strerror(rte_errno)); > > > + goto leave; > > > + } > > > > > > ret = eth_dev_tap_create(dev, tap_name, remote_iface, &user_mac, > > > > > > ETH_TUNTAP_TYPE_TAP); > > > > Is it an issue registering tap_mp_sync_queues at each tap probing? > > Should we do it only once? > > It should be as of per device so we should do it for each port alone since several ports can have different queues. > > Moreover, if the port that has the registration was closed or unplugged we'll not be able to sync qeues for other ports. I think we should do register on first tap device probing and never unregisters. Ferruh, any opinion?