* [dpdk-dev] [PATCH] igb_uio: change the irq print type.
@ 2018-01-23 16:17 xiangxia.m.yue
2018-02-05 23:17 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: xiangxia.m.yue @ 2018-01-23 16:17 UTC (permalink / raw)
To: ferruh.yigit; +Cc: dev, Tonghao Zhang
From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
The kernel uses the '%d' or '%ld' to print irq num.
But igb_uio may use the '%lx', then the log may confuse
the user what irq num has been used. The log is show as
below.
igb_uio 0000:00:03.0: irq 24 for MSI/MSI-X
igb_uio 0000:00:03.0: uio device registered with irq 18
kernel version: 3.10.0-514.16.1.el7
For avoiding to be confused, change the igb_uio irq
print type.
Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
---
lib/librte_eal/linuxapp/igb_uio/igb_uio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
index a3a98c1..81e44b5 100644
--- a/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
+++ b/lib/librte_eal/linuxapp/igb_uio/igb_uio.c
@@ -299,7 +299,7 @@ struct rte_uio_pci_dev {
err = request_irq(udev->info.irq, igbuio_pci_irqhandler,
udev->info.irq_flags, udev->info.name,
udev);
- dev_info(&udev->pdev->dev, "uio device registered with irq %lx\n",
+ dev_info(&udev->pdev->dev, "uio device registered with irq %ld\n",
udev->info.irq);
return err;
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [dpdk-dev] [PATCH] igb_uio: change the irq print type.
2018-01-23 16:17 [dpdk-dev] [PATCH] igb_uio: change the irq print type xiangxia.m.yue
@ 2018-02-05 23:17 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2018-02-05 23:17 UTC (permalink / raw)
To: xiangxia.m.yue; +Cc: dev, ferruh.yigit
23/01/2018 17:17, xiangxia.m.yue@gmail.com:
> From: Tonghao Zhang <xiangxia.m.yue@gmail.com>
>
> The kernel uses the '%d' or '%ld' to print irq num.
> But igb_uio may use the '%lx', then the log may confuse
> the user what irq num has been used. The log is show as
> below.
>
> igb_uio 0000:00:03.0: irq 24 for MSI/MSI-X
> igb_uio 0000:00:03.0: uio device registered with irq 18
>
> kernel version: 3.10.0-514.16.1.el7
>
> For avoiding to be confused, change the igb_uio irq
> print type.
>
> Signed-off-by: Tonghao Zhang <xiangxia.m.yue@gmail.com>
Applied, thanks
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-02-05 23:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-01-23 16:17 [dpdk-dev] [PATCH] igb_uio: change the irq print type xiangxia.m.yue
2018-02-05 23:17 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).