From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81C3AA04A5; Tue, 16 Jun 2020 18:12:36 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 7F5A31BF87; Tue, 16 Jun 2020 18:12:35 +0200 (CEST) Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id BBF3C1BF82 for ; Tue, 16 Jun 2020 18:12:33 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 487CA5C00C7; Tue, 16 Jun 2020 12:12:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Tue, 16 Jun 2020 12:12:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 0UzyHQuMwpS1eNwi+uC9CyvsN4ck2/oYdrsg90FhTWM=; b=Dtyq2IEL1oBBZ02E 7x8grEb23wsfRm5dhmJObBY6DecukDfBDxzmjJ52DbX3Ey3+Cin0RfUmkIuvgYlA JlqQBJRdQuipASpsFhdfnW1Vw/KBwTYV8jp2/OrFr+WNMhb5x+izJn2LE+yhfYOP 4Y0LXCPcx0b1rl/2DESJkc1Nl+mJeVhsroarIYuJWt1RUumDaE8cMJSPZ3yK+EJd TYO5QmP5blit4Wch5Q8oSybBQtjaMeGSEmvm0E4BpXawJ6B9P4slfiIolammt11z NLP2CMFwlKsyfeV2pnEKwWZ+U1u02+3YPH0q6eFXFD1OyhjeZP4IrWEGyTrCZ4fb 4J0RKQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=0UzyHQuMwpS1eNwi+uC9CyvsN4ck2/oYdrsg90FhT WM=; b=F6MKermUfsPhI4+thyY3T+r9vvQZJ6jiE7yrL18qhS2aFc2fzzhS5PweG u4gp76ncD3KTyTJPyymjxEyemQVU+zHTlU9VluVjwL5LYaeJdaNJAj2vPdEDug7h PEftgdGJuQ1zY4jRGBx9/j41GrNJXP/i0GN8uTx/yif0bjkv6nJxAc3AIktthhhe M7PK10QCqNx2P93oL8JjQQXIHCKMraPDfvRjhv0ZU3pT1bbddVXwbiT5B4SbvZUo 0z6EFkS1nXSQWRSgQ1C0ArxVekeV81ddVG0VwKYerlcFjX03KzniStZBk9wDe6KO rTSuEGB2dRN0yFRGKrOQTs/VqIUxQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrudejtddguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc ggtffrrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdej ueeiiedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgr lhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 1C47A30618B7; Tue, 16 Jun 2020 12:12:32 -0400 (EDT) From: Thomas Monjalon To: Stephen Hemminger Cc: Yipeng Wang , Sameh Gobriel , Bruce Richardson , dev@dpdk.org, honnappa.nagarahalli@arm.com, pablo.de.lara.guarch@intel.com Date: Tue, 16 Jun 2020 18:12:30 +0200 Message-ID: <1609609.4PBobdEyhI@thomas> In-Reply-To: <20200605113508.746ba6b2@hermes.lan> References: <20200604171731.6738-1-stephen@networkplumber.org> <20200605113508.746ba6b2@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] hash: document breakage with multi-writer thread X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 05/06/2020 20:35, Stephen Hemminger: > On Thu, 4 Jun 2020 10:17:31 -0700 > Stephen Hemminger wrote: > > > The code in rte_cuckoo_hash multi-writer support is broken if write > > operations are called from a non-EAL thread. > > > > rte_lcore_id() wil return LCORE_ID_ANY (UINT32_MAX) for non EAL > > thread and that leads to using wrong local cache. > > > > Add error checks and document the restriction. > > > > Fixes: 9d033dac7d7c ("hash: support no free on delete") > > Fixes: 5915699153d7 ("hash: fix scaling by reducing contention") > > Signed-off-by: Stephen Hemminger > > Cc: honnappa.nagarahalli@arm.com > > Cc: pablo.de.lara.guarch@intel.com > > This restriction also needs to be added to the known issues > section of EAL Are you going to send a v2 adding doc?