From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 48A42293B for ; Tue, 4 Apr 2017 16:01:32 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id x124so28837630wmf.0 for ; Tue, 04 Apr 2017 07:01:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=SKPNN3Z+Mi6t9j1cOexZ6KQuuTizy6SeHsF5Gd/N8oQ=; b=1Q6L5RBZc7Pvropi+H3jrpkpjJ/ErZR1DGji1Fs3kNXPEk1SyRktcwGX0QGAVlufrO Zb86LMJIRT+11kkspDoQ0UXiRcrQEK8tehRN0QplLDe4ifvkN9XEcuRSCVymRUvvr6gj Ut4V7/+IqvAo9xuLeAcYxsGsykd0NcUbOcQS5/zCVDgH+EF9TIqRNT0dVrcSUI11pq/b IMqsSUfBzuYLa6F/M/qO8xJqC7SU+TC3oCtliCw9EzUyzk/st/2yR+fzftaBT4yywnde RlRDAOQ0/dbM/soO1ucVdZUyvp/3lcE9kq24UZwKqa08+A5vxiWVaCKiXGuMOV/kY/wo q5NA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=SKPNN3Z+Mi6t9j1cOexZ6KQuuTizy6SeHsF5Gd/N8oQ=; b=YLllFwPZiqWjTTVmXdjkUwufjrHLBmSBc5PbQ3EutlGXsoC9y3jFiTwD/yIg3PZN9v GgJaYqdEfZ4f7e9Jcaq/Mnlp933EFxCykYRVAV0N9P6hoVnINBzSUYiKiAUh5kv5yPfE SoPq483JnTTY/zFipvIcnHCTPpzv+u9EvxaDnpd3a4hwo3FrykShX2mxd/6gzdripuVv W0lvaGu0DxReq43EnGgU3N1RPVR0NoEL5+VHxhXb5AfKf+cKsg6DqoMBYLnr27Dcnz0U wtEu0f486m2QN6aqKnWgk1Y/R8dMsNvOORc4qWTv+nnOk5v6RfsQs3qAGqV5DgZifVDu S/4Q== X-Gm-Message-State: AFeK/H3uAIVBItP/cyCWm+FjnM8x8hQ9vRBdDSFSEfzlR+j274wAlRSO LYRTiQrC0AkbuT/dvK0= X-Received: by 10.28.225.69 with SMTP id y66mr15270023wmg.84.1491314491890; Tue, 04 Apr 2017 07:01:31 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id u66sm18606255wmd.24.2017.04.04.07.01.30 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Apr 2017 07:01:31 -0700 (PDT) From: Thomas Monjalon To: Aaron Conole Cc: dev@dpdk.org Date: Tue, 04 Apr 2017 16:01:30 +0200 Message-ID: <1610139.QdKl0Sncku@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <20170331183122.22961-1-aconole@redhat.com> <2833575.ok4SoAkeVM@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] eal: deprecate rte_cpu_check_supported X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 14:01:32 -0000 2017-04-04 09:39, Aaron Conole: > Hi Thomas, > > Thomas Monjalon writes: > > > 2017-03-31 14:31, Aaron Conole: > >> It's likely that this function isn't used anywhere, but since it was part of > >> the public API, mark the function for deprecation for at least one release. > >> > >> Signed-off-by: Aaron Conole > > Thanks so much for the review! I'll make sure to fix these with v2. > > > [...] > >> +DPDK_17.05 { > >> + global; > >> + > >> + rte_cpu_is_supported; > >> + > >> +} DPDK_17.02; > > > > Should not it be a separate patch? > > I thought it made sense to keep it rolled in with this patch, but if you > prefer it separate, I will do that. Expect it as 1/2 in v2, unless you > say otherwise. Yes 2 patches in v2. Thanks