DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] app/testpmd: fix queue reconfig request on Rx split update
@ 2021-01-21 12:46 Viacheslav Ovsiienko
  2021-01-29 16:51 ` Ferruh Yigit
  0 siblings, 1 reply; 2+ messages in thread
From: Viacheslav Ovsiienko @ 2021-01-21 12:46 UTC (permalink / raw)
  To: dev
  Cc: thomas, ferruh.yigit, beilei.xing, bernard.iremonger, wenzhuo.lu, stable

There is the "set rxpkts" command in the testpmd interactive mode,
it configures the segment sizes to split the packet on receiving.
The mentioned segment sizes are provided on the Rx queue setup
as part of queue configuration. Hence, to take the rxpkts command
into effect the Rx queues must be explicitly reconfigured.

The explained above is related to the "set rxoffs" as well.

The patch sets the queue reconfiguration request flag for
all devices once Rx split settings are updated, to take
the changes into effect the port(s) should be restarted.

Fixes: 0f2096d7ab36 ("app/testpmd: add rxpkts commands and parameters")
Fixes: 91c78e090eed ("app/testpmd: add rxoffs commands and parameters")
Cc: stable@dpdk.org

Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>
---
 app/test-pmd/cmdline.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 0d2d6aa..3ffc7bf 100644
--- a/app/test-pmd/cmdline.c
+++ b/app/test-pmd/cmdline.c
@@ -3782,6 +3782,7 @@ struct cmd_set_rxoffs_result {
 				  MAX_SEGS_BUFFER_SPLIT, seg_offsets, 0);
 	if (nb_segs > 0)
 		set_rx_pkt_offsets(seg_offsets, nb_segs);
+	cmd_reconfig_device_queue(RTE_PORT_ALL, 0, 1);
 }
 
 cmdline_parse_token_string_t cmd_set_rxoffs_keyword =
@@ -3828,6 +3829,7 @@ struct cmd_set_rxpkts_result {
 				  MAX_SEGS_BUFFER_SPLIT, seg_lengths, 0);
 	if (nb_segs > 0)
 		set_rx_pkt_segments(seg_lengths, nb_segs);
+	cmd_reconfig_device_queue(RTE_PORT_ALL, 0, 1);
 }
 
 cmdline_parse_token_string_t cmd_set_rxpkts_keyword =
-- 
1.8.3.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [dpdk-dev] [PATCH] app/testpmd: fix queue reconfig request on Rx split update
  2021-01-21 12:46 [dpdk-dev] [PATCH] app/testpmd: fix queue reconfig request on Rx split update Viacheslav Ovsiienko
@ 2021-01-29 16:51 ` Ferruh Yigit
  0 siblings, 0 replies; 2+ messages in thread
From: Ferruh Yigit @ 2021-01-29 16:51 UTC (permalink / raw)
  To: Viacheslav Ovsiienko, dev
  Cc: thomas, beilei.xing, bernard.iremonger, wenzhuo.lu, stable

On 1/21/2021 12:46 PM, Viacheslav Ovsiienko wrote:
> There is the "set rxpkts" command in the testpmd interactive mode,
> it configures the segment sizes to split the packet on receiving.
> The mentioned segment sizes are provided on the Rx queue setup
> as part of queue configuration. Hence, to take the rxpkts command
> into effect the Rx queues must be explicitly reconfigured.
> 
> The explained above is related to the "set rxoffs" as well.
> 
> The patch sets the queue reconfiguration request flag for
> all devices once Rx split settings are updated, to take
> the changes into effect the port(s) should be restarted.
> 
> Fixes: 0f2096d7ab36 ("app/testpmd: add rxpkts commands and parameters")
> Fixes: 91c78e090eed ("app/testpmd: add rxoffs commands and parameters")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Viacheslav Ovsiienko <viacheslavo@nvidia.com>

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

Applied to dpdk-next-net/main, thanks.


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-01-29 16:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-21 12:46 [dpdk-dev] [PATCH] app/testpmd: fix queue reconfig request on Rx split update Viacheslav Ovsiienko
2021-01-29 16:51 ` Ferruh Yigit

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git