From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 340A61B781 for ; Fri, 13 Oct 2017 21:31:46 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C8CAB20CA6; Fri, 13 Oct 2017 15:31:45 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute1.internal (MEProxy); Fri, 13 Oct 2017 15:31:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=ZN9o87HxIgpqKg9UOKCMKRtrwp Eh9DPZBRmiNvUlyW4=; b=IokFKNID+ZiwMQMQzzOqHKEzL5XCLngtgWkVbSYMQB MO6EDbLorX3Crp9lKskYPTyOZQZeXhqDJ1uj3eWdUg0oxKf/H3O3S5W4//434ROw y3Rt+3lE+wGTTA5/Ps872e7TrDQBdMDiXdg6dKIAyOCbOgw20cVjmkAw3tgLmWdP A= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=ZN9o87 HxIgpqKg9UOKCMKRtrwpEh9DPZBRmiNvUlyW4=; b=CGvWtdYcksDlMB9EvJLpHh RQtdjzGSwKv5XdMppV6xj48PkrIbzLpF+r8b/nVoS2Cl7cbhbye7L94OCiQempK3 z+V2k0vW30u2Z8pc4reAbc2IH9DDCJBpphGwJby6g+gXoSr4sj9qnQNIxk9xsrdq BZTiH2+TCYYL9BRZUcq2C6yZEFbNQhOOLmlZFeMY1Z8fgQ1LXK3+mFApVoYjQ9M4 zdXa5Ce5HoL3yscd1y4Y8Yv8ht5MK0axo9nuKgj8g9F9YjA7ym8PBKd3JwgZuQ4e bPWBJdvBqVqoFiHZbQqPlw06cURjxLrAhAshEQfc6vbx70jzJyhEXH0M4innV/Qw == X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 746012479F; Fri, 13 Oct 2017 15:31:45 -0400 (EDT) From: Thomas Monjalon To: Maxime Coquelin Cc: dev@dpdk.org, Jens Freimann , yliu@fridaylinux.org, lei.a.yao@intel.com Date: Fri, 13 Oct 2017 21:31:44 +0200 Message-ID: <1611613.caVE2u6YoK@xps> In-Reply-To: <20171013094347.oq7nwfnbm3yj7zkt@dhcp-192-218.str.redhat.com> References: <20171013093021.3196-1-maxime.coquelin@redhat.com> <20171013094347.oq7nwfnbm3yj7zkt@dhcp-192-218.str.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] vhost: fetch again ring_addrs address after NUMA reallocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 13 Oct 2017 19:31:46 -0000 13/10/2017 11:43, Jens Freimann: > On Fri, Oct 13, 2017 at 09:30:21AM +0000, Maxime Coquelin wrote: > >In case of NUMA reallocation, the virtqueue struct is reallocated > >on another socket, meaning that its address changes. > > > >In translate_ring_addresses(), addr pointer was not fetched again > >after the reallocation, so it pointed to freed memory. > > > >This patch just fetch again addr pointer after the reallocation. > > > >Reported-by: Yao, Lei A > >Tested-by: Yao, Lei A > >Signed-off-by: Maxime Coquelin > > Reviewed-by: Jens Freimann Applied, thanks