DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] bus/fslmc: fixes missing brace
@ 2017-07-11  8:50 Hemant Agrawal
  2017-07-11  9:18 ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Hemant Agrawal @ 2017-07-11  8:50 UTC (permalink / raw)
  To: dev, thomas, stephen

Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")

Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
---
 drivers/bus/fslmc/fslmc_bus.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bus/fslmc/fslmc_bus.c b/drivers/bus/fslmc/fslmc_bus.c
index 60eb8d2..f71598d 100644
--- a/drivers/bus/fslmc/fslmc_bus.c
+++ b/drivers/bus/fslmc/fslmc_bus.c
@@ -113,7 +113,7 @@ rte_fslmc_find_device(const struct rte_device *start, rte_dev_cmp_t cmp,
 	struct rte_dpaa2_device *dev;
 
 	TAILQ_FOREACH(dev, &rte_fslmc_bus.device_list, next) {
-		if (start && &dev->device == start)
+		if (start && &dev->device == start) {
 			start = NULL;  /* starting point found */
 			continue;
 		}
-- 
2.7.4

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/fslmc: fixes missing brace
  2017-07-11  8:50 [dpdk-dev] [PATCH] bus/fslmc: fixes missing brace Hemant Agrawal
@ 2017-07-11  9:18 ` Thomas Monjalon
  2017-07-11 11:30   ` Hemant Agrawal
  0 siblings, 1 reply; 3+ messages in thread
From: Thomas Monjalon @ 2017-07-11  9:18 UTC (permalink / raw)
  To: Hemant Agrawal; +Cc: dev, stephen

11/07/2017 10:50, Hemant Agrawal:
> Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")
> 
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>

That's why review is important :)
I should add dpaa2 target in my compilation tests.

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] bus/fslmc: fixes missing brace
  2017-07-11  9:18 ` Thomas Monjalon
@ 2017-07-11 11:30   ` Hemant Agrawal
  0 siblings, 0 replies; 3+ messages in thread
From: Hemant Agrawal @ 2017-07-11 11:30 UTC (permalink / raw)
  To: Thomas Monjalon, stephen; +Cc: dev

On 7/11/2017 2:48 PM, Thomas Monjalon wrote:
> 11/07/2017 10:50, Hemant Agrawal:
>> Fixes: c7fe1eea8a74 ("bus: simplify finding starting point")
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>
> That's why review is important :)

It is generally expected that the submitter will check the compilation 
or he will at the least tag the respective maintainer for the same.

> I should add dpaa2 target in my compilation tests.
>
yes please. Thanks!

> Applied, thanks
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-07-11 11:30 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-11  8:50 [dpdk-dev] [PATCH] bus/fslmc: fixes missing brace Hemant Agrawal
2017-07-11  9:18 ` Thomas Monjalon
2017-07-11 11:30   ` Hemant Agrawal

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).