From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F047CA052A; Tue, 26 Jan 2021 13:53:55 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 20C761414A1; Tue, 26 Jan 2021 13:53:45 +0100 (CET) Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by mails.dpdk.org (Postfix) with ESMTP id C6760141493 for ; Tue, 26 Jan 2021 13:53:38 +0100 (CET) Received: from Internal Mail-Server by MTLPINE1 (envelope-from jiaweiw@nvidia.com) with SMTP; 26 Jan 2021 14:53:34 +0200 Received: from nvidia.com (gen-l-vrt-281.mtl.labs.mlnx [10.237.44.1]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id 10QCrXBr022427; Tue, 26 Jan 2021 14:53:33 +0200 From: Jiawei Wang To: viacheslavo@nvidia.com, matan@nvidia.com, orika@nvidia.com, thomas@monjalon.net Cc: dev@dpdk.org, rasland@nvidia.com, stable@dpdk.org Date: Tue, 26 Jan 2021 14:53:32 +0200 Message-Id: <1611665613-123388-2-git-send-email-jiaweiw@nvidia.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1611665613-123388-1-git-send-email-jiaweiw@nvidia.com> References: <1611665613-123388-1-git-send-email-jiaweiw@nvidia.com> Subject: [dpdk-dev] [PATCH 1/2] net/mlx5: fix the E-Switch sample action creation failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" This patch fixes the incorrect checking for the return value of default miss action creation. Fixes: 14020ad53d4e ("net/mlx5: wrap default miss flow action per OS") Cc: stable@dpdk.org Signed-off-by: Jiawei Wang Acked-by: Viacheslav Ovsiienko --- drivers/net/mlx5/mlx5_flow_dv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c index 1a0c0be..27d711d 100644 --- a/drivers/net/mlx5/mlx5_flow_dv.c +++ b/drivers/net/mlx5/mlx5_flow_dv.c @@ -9155,7 +9155,7 @@ struct mlx5_cache_entry * if (resource->ft_type == MLX5DV_FLOW_TABLE_TYPE_FDB) { ret = mlx5_flow_os_create_flow_action_default_miss (&cache_resource->default_miss); - if (!ret) { + if (ret) { rte_flow_error_set(error, ENOMEM, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, -- 1.8.3.1