* [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error
@ 2021-04-27 8:51 Min Hu (Connor)
2021-04-27 13:22 ` Wang, Haiyue
0 siblings, 1 reply; 5+ messages in thread
From: Min Hu (Connor) @ 2021-04-27 8:51 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, jia.guo, haiyue.wang
This patch fixes parameter misusage when set rte flow action error.
Fixes: c0688ef1eded ("net/igb: parse flow API n-tuple filter")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/net/e1000/igb_flow.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c
index 33f6b1d..e72376f 100644
--- a/drivers/net/e1000/igb_flow.c
+++ b/drivers/net/e1000/igb_flow.c
@@ -350,7 +350,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr,
memset(filter, 0, sizeof(struct rte_eth_ntuple_filter));
rte_flow_error_set(error, EINVAL,
RTE_FLOW_ERROR_TYPE_ACTION,
- item, "Not supported action.");
+ act, "Not supported action.");
return -rte_errno;
}
filter->queue =
--
2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error 2021-04-27 8:51 [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error Min Hu (Connor) @ 2021-04-27 13:22 ` Wang, Haiyue 2021-04-28 1:15 ` Min Hu (Connor) 2021-04-28 1:26 ` Zhang, Qi Z 0 siblings, 2 replies; 5+ messages in thread From: Wang, Haiyue @ 2021-04-27 13:22 UTC (permalink / raw) To: Min Hu (Connor), dev; +Cc: Yigit, Ferruh, Guo, Jia > -----Original Message----- > From: Min Hu (Connor) <humin29@huawei.com> > Sent: Tuesday, April 27, 2021 16:51 > To: dev@dpdk.org > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue > <haiyue.wang@intel.com> > Subject: [PATCH] net/e1000: fix param misusage when set rte flow error > > This patch fixes parameter misusage when set rte flow action error. > > Fixes: c0688ef1eded ("net/igb: parse flow API n-tuple filter") > Cc: stable@dpdk.org > > Signed-off-by: Min Hu (Connor) <humin29@huawei.com> > --- > drivers/net/e1000/igb_flow.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Acked-by: Haiyue Wang <haiyue.wang@intel.com> > diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c > index 33f6b1d..e72376f 100644 > --- a/drivers/net/e1000/igb_flow.c > +++ b/drivers/net/e1000/igb_flow.c > @@ -350,7 +350,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, > memset(filter, 0, sizeof(struct rte_eth_ntuple_filter)); > rte_flow_error_set(error, EINVAL, > RTE_FLOW_ERROR_TYPE_ACTION, > - item, "Not supported action."); > + act, "Not supported action."); Thanks, Connor. Just wonder how do you get this error ? With some code scan tool ? ;-) > return -rte_errno; > } > filter->queue = > -- > 2.7.4 ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error 2021-04-27 13:22 ` Wang, Haiyue @ 2021-04-28 1:15 ` Min Hu (Connor) 2021-04-28 1:18 ` Wang, Haiyue 2021-04-28 1:26 ` Zhang, Qi Z 1 sibling, 1 reply; 5+ messages in thread From: Min Hu (Connor) @ 2021-04-28 1:15 UTC (permalink / raw) To: Wang, Haiyue, dev; +Cc: Yigit, Ferruh, Guo, Jia 在 2021/4/27 21:22, Wang, Haiyue 写道: >> -----Original Message----- >> From: Min Hu (Connor) <humin29@huawei.com> >> Sent: Tuesday, April 27, 2021 16:51 >> To: dev@dpdk.org >> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue >> <haiyue.wang@intel.com> >> Subject: [PATCH] net/e1000: fix param misusage when set rte flow error >> >> This patch fixes parameter misusage when set rte flow action error. >> >> Fixes: c0688ef1eded ("net/igb: parse flow API n-tuple filter") >> Cc: stable@dpdk.org >> >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> >> --- >> drivers/net/e1000/igb_flow.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> > > Acked-by: Haiyue Wang <haiyue.wang@intel.com> > > >> diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c >> index 33f6b1d..e72376f 100644 >> --- a/drivers/net/e1000/igb_flow.c >> +++ b/drivers/net/e1000/igb_flow.c >> @@ -350,7 +350,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, >> memset(filter, 0, sizeof(struct rte_eth_ntuple_filter)); >> rte_flow_error_set(error, EINVAL, >> RTE_FLOW_ERROR_TYPE_ACTION, >> - item, "Not supported action."); >> + act, "Not supported action."); > > Thanks, Connor. > > Just wonder how do you get this error ? With some code scan tool ? ;-) > No, I just read your code to help me understand flow table. I found this part of codes are the same as others. So I think this mistake derived from other drivers. >> return -rte_errno; >> } >> filter->queue = >> -- >> 2.7.4 > > . > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error 2021-04-28 1:15 ` Min Hu (Connor) @ 2021-04-28 1:18 ` Wang, Haiyue 0 siblings, 0 replies; 5+ messages in thread From: Wang, Haiyue @ 2021-04-28 1:18 UTC (permalink / raw) To: Min Hu (Connor), dev; +Cc: Yigit, Ferruh, Guo, Jia > -----Original Message----- > From: Min Hu (Connor) <humin29@huawei.com> > Sent: Wednesday, April 28, 2021 09:16 > To: Wang, Haiyue <haiyue.wang@intel.com>; dev@dpdk.org > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com> > Subject: Re: [PATCH] net/e1000: fix param misusage when set rte flow error > > > > 在 2021/4/27 21:22, Wang, Haiyue 写道: > >> -----Original Message----- > >> From: Min Hu (Connor) <humin29@huawei.com> > >> Sent: Tuesday, April 27, 2021 16:51 > >> To: dev@dpdk.org > >> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com>; Wang, Haiyue > >> <haiyue.wang@intel.com> > >> Subject: [PATCH] net/e1000: fix param misusage when set rte flow error > >> > >> This patch fixes parameter misusage when set rte flow action error. > >> > >> Fixes: c0688ef1eded ("net/igb: parse flow API n-tuple filter") > >> Cc: stable@dpdk.org > >> > >> Signed-off-by: Min Hu (Connor) <humin29@huawei.com> > >> --- > >> drivers/net/e1000/igb_flow.c | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > > > > Acked-by: Haiyue Wang <haiyue.wang@intel.com> > > > > > >> diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c > >> index 33f6b1d..e72376f 100644 > >> --- a/drivers/net/e1000/igb_flow.c > >> +++ b/drivers/net/e1000/igb_flow.c > >> @@ -350,7 +350,7 @@ cons_parse_ntuple_filter(const struct rte_flow_attr *attr, > >> memset(filter, 0, sizeof(struct rte_eth_ntuple_filter)); > >> rte_flow_error_set(error, EINVAL, > >> RTE_FLOW_ERROR_TYPE_ACTION, > >> - item, "Not supported action."); > >> + act, "Not supported action."); > > > > Thanks, Connor. > > > > Just wonder how do you get this error ? With some code scan tool ? ;-) > > > No, I just read your code to help me understand flow table. I found this > part of codes are the same as others. > So I think this mistake derived from other drivers. OK, understood. ;-) > >> return -rte_errno; > >> } > >> filter->queue = > >> -- > >> 2.7.4 > > > > . > > ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error 2021-04-27 13:22 ` Wang, Haiyue 2021-04-28 1:15 ` Min Hu (Connor) @ 2021-04-28 1:26 ` Zhang, Qi Z 1 sibling, 0 replies; 5+ messages in thread From: Zhang, Qi Z @ 2021-04-28 1:26 UTC (permalink / raw) To: Wang, Haiyue, Min Hu (Connor), dev; +Cc: Yigit, Ferruh, Guo, Jia > -----Original Message----- > From: dev <dev-bounces@dpdk.org> On Behalf Of Wang, Haiyue > Sent: Tuesday, April 27, 2021 9:23 PM > To: Min Hu (Connor) <humin29@huawei.com>; dev@dpdk.org > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia <jia.guo@intel.com> > Subject: Re: [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte > flow error > > > -----Original Message----- > > From: Min Hu (Connor) <humin29@huawei.com> > > Sent: Tuesday, April 27, 2021 16:51 > > To: dev@dpdk.org > > Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Guo, Jia > > <jia.guo@intel.com>; Wang, Haiyue <haiyue.wang@intel.com> > > Subject: [PATCH] net/e1000: fix param misusage when set rte flow error > > > > This patch fixes parameter misusage when set rte flow action error. > > > > Fixes: c0688ef1eded ("net/igb: parse flow API n-tuple filter") > > Cc: stable@dpdk.org > > > > Signed-off-by: Min Hu (Connor) <humin29@huawei.com> > > --- > > drivers/net/e1000/igb_flow.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > Acked-by: Haiyue Wang <haiyue.wang@intel.com> Applied to dpdk-next-net-intel. Thanks Qi ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-04-28 1:26 UTC | newest] Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2021-04-27 8:51 [dpdk-dev] [PATCH] net/e1000: fix param misusage when set rte flow error Min Hu (Connor) 2021-04-27 13:22 ` Wang, Haiyue 2021-04-28 1:15 ` Min Hu (Connor) 2021-04-28 1:18 ` Wang, Haiyue 2021-04-28 1:26 ` Zhang, Qi Z
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).