From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 204F1A04DC; Mon, 19 Oct 2020 10:24:21 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4EE0EAD52; Mon, 19 Oct 2020 10:24:19 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id ED045ACE4 for ; Mon, 19 Oct 2020 10:24:17 +0200 (CEST) Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 777FE5C00F7; Mon, 19 Oct 2020 04:24:16 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Mon, 19 Oct 2020 04:24:16 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm2; bh= j1QC/qIjso3VX16qvlNBPULRHvdUQwh9PuYddMih4VU=; b=SFR7SjY/l4MQOalE qrXva0V6SWOwFHg60UXNtm5ketyD3DpRi7p1GBhuzrrUGVC7aVIW0rBBCawGt+FV JM8p9sa4WFtqhoxwVZkIxbzz38zBFJ+wFvG6pOm72zzg6OqFytwdYRwab/iS9kJE z5Q5Wosoa7pUwf9cMe+w2ZuEIvX7BMeMK+cNKfV8DdGHHM6xY5h8WZYZjUditaWe l4+/QeBei8B2B3vO8LihUWcYk2ywtIP0hCZcag6O2uw7wbA9KIWgF40tfBy8YQwC 3QTervnGDeHTta4mNEcF9EnRy3qpVxjlDc+4beFdiVfSr6oJ7iVyFh+iZSqMaAsZ YysjEA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=j1QC/qIjso3VX16qvlNBPULRHvdUQwh9PuYddMih4 VU=; b=MYjuvMj3AOmukH7ZCkcFH9RI4Xb49FUg+JzOINCmqhX7zmkJTr+6rzPFI iKQ5tdyXR4Y7mrI1MpsyxrzsrX5G3MFosoU/f7vWHcmV7eGxa8iwVKmaBoMwU8z7 fEjhJjN4ilpqynfgVlIsgXUNsGBpXOt/g6oiavgtu4m3gnzChomcqOQCxbPgZkiB jsZBJUR/y4X4gY8IY3esqCq2YCOawyRvW1LD8WAlCjr3A18Bpn7os7TcU2emAKt9 SZ+n0FiwGgdumLlmWf3c6eQjqnOkmeYY2CEXbYqncRx36hpLWq5wKGbqtgOTfLyV dhdCGizQiP2HjGXGQIajZ9X8mMRsQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjedugddtgecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho nhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 6F0A1306467D; Mon, 19 Oct 2020 04:24:15 -0400 (EDT) From: Thomas Monjalon To: Kevin Laatz Cc: dev@dpdk.org, Bruce Richardson Date: Mon, 19 Oct 2020 10:24:13 +0200 Message-ID: <1612337.XWASpXRTfn@thomas> In-Reply-To: <20201014110010.GE1513@bricha3-MOBL.ger.corp.intel.com> References: <20201014101110.1210264-1-kevin.laatz@intel.com> <20201014110010.GE1513@bricha3-MOBL.ger.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] raw/ioat: fix dereference before null check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 14/10/2020 13:34, Bruce Richardson: > On Wed, Oct 14, 2020 at 11:11:10AM +0100, Kevin Laatz wrote: > > The 'idxd' pointer in 'idxd_rawdev_destroy()' is being dereferenced before > > it is checked. To fix this, the null pointer check was moved to occur > > earlier in the code. > > > > Coverity issue: 363040 > > Fixes: ff06fa2cf3ba ("raw/ioat: probe idxd PCI") > > > > Signed-off-by: Kevin Laatz > > --- > Acked-by: Bruce Richardson Applied, thanks