From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas.monjalon@6wind.com> Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 0FECA37B2 for <dev@dpdk.org>; Thu, 30 Jun 2016 22:05:59 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id v199so972022wmv.0 for <dev@dpdk.org>; Thu, 30 Jun 2016 13:05:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=B+L4RLJx5NKnyr49Erk23GW5QxUB96TPjDtPq6FikvE=; b=S7huf2Lu1XBQV6wdN7BoVlmZWiSVNImRCDGiDMmtWTYJVXCEZ+YMm49FZOtZTKtXVt 1kAamV/KmgFpz4vTcpuvz+rCoBe5/EL4OA6miE97AZhjEMVc4L+tySfGY1TURaL0gs8s 1NyzEGvr4UjqPSDC+ecMwc9+djaVyrhN/UiUHq4XQO9ScXmBwr3672l06Fbhw0VUdsb9 VGNwCv9eMBFvNb4+DRWetGEChKRqD5Ue3AQjkhutxX+PY5fLSFJTB6VU8CyfsJDT77Yp EYFwvi7h0buQAb+R1uAWIZmFB6d9TkyNQBUSCI4v8o+X8PVN3pLngM8Xx6BlVVJzwTOL wOGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=B+L4RLJx5NKnyr49Erk23GW5QxUB96TPjDtPq6FikvE=; b=jmmq5n4CX83FlsT8LxLDUEQ1Vt2Z95rNJuAoBhxZUxSY/4CmsBMei7MYUbYCecSGHU pjrlJNIshPrzs024HEV9YmbRPujNP7LuN/kjXe4zHyBKBs381VeQ/aHxZrcY2JAFCV5l K5wsP/z+tb3FyInveW/iH3NJjPm5QUbefZXnkesUBpYRwluWYDTfFlqHr4720SKjRhtY dg3JDUyzTWWlTIkaUFeXYuh58gl0sd16fe8ZbvjgHMUf0QzeawQo0hXneHz950mo6shT LsDDbqF13bdFli22FPxvHf83rNV5pXCpVznwfuOsFWFBJTyRhXW5EqSVjbp1VCEhUQqT BcVA== X-Gm-Message-State: ALyK8tI+sAWNiaaOMQvzaB/qmCK0wSVTX1eiBAzHxcK0w2zedvWSTbdzrcfIKi/EMPVj1k3t X-Received: by 10.28.107.23 with SMTP id g23mr30531149wmc.101.1467317158849; Thu, 30 Jun 2016 13:05:58 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id f189sm261606wmf.19.2016.06.30.13.05.56 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 30 Jun 2016 13:05:56 -0700 (PDT) From: Thomas Monjalon <thomas.monjalon@6wind.com> To: Bruce Richardson <bruce.richardson@intel.com> Cc: dev@dpdk.org, olivier.matz@6wind.com, keith.wiles@intel.com, Panu Matilainen <pmatilai@redhat.com> Date: Thu, 30 Jun 2016 22:05:55 +0200 Message-ID: <1613474.aBI9rN0qDz@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1467290965-3797-1-git-send-email-bruce.richardson@intel.com> References: <1467208504-13029-1-git-send-email-bruce.richardson@intel.com> <1467290965-3797-1-git-send-email-bruce.richardson@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v3] mempool: rename functions with confusing names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 30 Jun 2016 20:05:59 -0000 2016-06-30 13:49, Bruce Richardson: > The mempool_count and mempool_free_count behaved contrary to what their > names suggested. The free_count function actually returned the number of > elements that were allocated from the pool, not the number unallocated as > the name implied. > > Fix this by introducing two new functions to replace the old ones, > * rte_mempool_avail_count to replace rte_mempool_count > * rte_mempool_in_use_count to replace rte_mempool_free_count > > In this patch, the new functions are added, and the old ones are marked > as deprecated. All apps and examples that use the old functions are > updated to use the new functions. The ThunderX driver uses rte_mempool_count and needs an update. Except that, it looks good.