From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BD7CA057B; Thu, 2 Apr 2020 13:13:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1C6BE2C15; Thu, 2 Apr 2020 13:13:48 +0200 (CEST) Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id B58562BCE for ; Thu, 2 Apr 2020 13:13:46 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 271EA5C0281; Thu, 2 Apr 2020 07:13:45 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute7.internal (MEProxy); Thu, 02 Apr 2020 07:13:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=LCTYW876+fe/V+Pre6cRTldD6S81SKZlNShyKJSvXOU=; b=NHGCHczwMcwi B0iOPt7ZRnes/KcJ7xYdMQyn7xy0jwd/40Bg15xJT/YaMX0fESISGeJriLj9jKj5 ExllHTAan88cJrWVmVLcX9BfUM6wimLJZMXrFjhrk7U3u3S82+RuNNEh92ZgB5hI YknP4v28b3/ao1v2Hg4R9LSWNCyyQH8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=LCTYW876+fe/V+Pre6cRTldD6S81SKZlNShyKJSvX OU=; b=zrvzrKq56gAIiuVO+11Z+4877Ny5qFyhKpykN3Mqaib8nOtDRXRIZhCgW NUomHx94Bib3m9Hqdlm3B4dKCQx4ZGP/B7EAMiiIePPfHiBmJjsUqjfjpVgJy807 Z5F80RgmjQyDYYRa1z+4rQd51vDMHIK709+bockc85/HD09SKZ2VJtiO/xESLde1 GfvsDKBsrDJhbF/dCsNHDt8KLki6p6817as0dGDEZc9D4x2KwnzanZpp0S1DZ/+N zsYaUV2ZW5g8aDsgMpwToioQQluBdZGnpAgevSj78sQylD7grE1HBTgwY5I5uhTC u1+IfjfPRvqXhGfObEuI0v3ngXWiw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrtdeggdefvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucfkph epjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuihiivgeptdenucfrrghr rghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvth X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 082D73280066; Thu, 2 Apr 2020 07:13:43 -0400 (EDT) From: Thomas Monjalon To: Viacheslav Ovsiienko Cc: dev@dpdk.org, ferruh.yigit@intel.com, bernard.iremonger@intel.com Date: Thu, 02 Apr 2020 13:13:42 +0200 Message-ID: <1613633.jCs4IzH5c6@xps> In-Reply-To: <1584625851-10291-1-git-send-email-viacheslavo@mellanox.com> References: <1561553317-16777-1-git-send-email-viacheslavo@mellanox.com> <1584625851-10291-1-git-send-email-viacheslavo@mellanox.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2 0/3] app/testpmd: qualify Rx/Tx profiling data on burst size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 19/03/2020 14:50, Viacheslav Ovsiienko: > There is the CONFIG_RTE_TEST_PMD_RECORD_CORE_CYCLES configuration > parameter enabling the lightweight profiler for the forwarding > routines that provides the time spent in the routines and estimates > the CPU cycles required to process one packet. > > It would be good to have separated data for the Rx and Tx directions. > Beside this, the performance depends on the actual burst size, the profiling > data per burst size are meaningful and would help detect the performance > anomalies. > > To control this profiling statistics the new testpmd command is introduced: > > set fwdprof (flags) > > This command controls which profiling statistics is being gathered > in runtime: > > - bit 0 - enables profiling the entire forward routine, counts the ticks > spent in the forwarding routine, is set by default. Provides > the same data as previous implementation. > > - bit 1 - enables gathering the profiling data for the transmit datapath, > counts the ticks spent within rte_eth_tx_burst() routine, > is cleared by default, extends the existing statistics. > > - bit 2 - enables gathering the profiling data for the receive datapath, > counts the ticks spent within rte_eth_rx_burst() routine, > is cleared by default, extends the existing statistics. Please can you rename bit 1 to Rx, and bit 2 to Tx, and implement configuration with text parsing instead of obscure bitflags? It would be more user-friendly, thanks.