DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] i40e: fix set max frame size to default
@ 2015-12-15 14:52 Jingjing Wu
  2015-12-15 16:01 ` Zhang, Helin
  0 siblings, 1 reply; 3+ messages in thread
From: Jingjing Wu @ 2015-12-15 14:52 UTC (permalink / raw)
  To: dev; +Cc: shijiex.dong

In FreeBsd driver, the max frame size is changed to MTU, but not
keep the default value defined in DataSheet. When DPDK runs on that
NIC, the configured value is not expected.
This patch sets the max frame size to default when initialization.

Fixes: 4861cde46116 ("i40e: new poll mode driver")

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
---
 drivers/net/i40e/i40e_ethdev.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index 22b240c..bf6220d 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -919,6 +919,11 @@ eth_i40e_dev_init(struct rte_eth_dev *dev)
 	 */
 	i40e_add_tx_flow_control_drop_filter(pf);
 
+	/* Set the max frame size to 0x2600 by default,
+	 * in case other drivers changed the default value.
+	 */
+	i40e_aq_set_mac_config(hw, I40E_FRAME_SIZE_MAX, TRUE, 0, NULL);
+
 	/* initialize mirror rule list */
 	TAILQ_INIT(&pf->mirror_list);
 
-- 
2.4.0

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] i40e: fix set max frame size to default
  2015-12-15 14:52 [dpdk-dev] [PATCH] i40e: fix set max frame size to default Jingjing Wu
@ 2015-12-15 16:01 ` Zhang, Helin
  2015-12-15 16:23   ` Thomas Monjalon
  0 siblings, 1 reply; 3+ messages in thread
From: Zhang, Helin @ 2015-12-15 16:01 UTC (permalink / raw)
  To: Wu, Jingjing, dev; +Cc: Dong, ShijieX



-----Original Message-----
From: Wu, Jingjing 
Sent: Tuesday, December 15, 2015 10:53 PM
To: dev@dpdk.org
Cc: Wu, Jingjing <jingjing.wu@intel.com>; Zhang, Helin <helin.zhang@intel.com>; Dong, ShijieX <shijiex.dong@intel.com>
Subject: [PATCH] i40e: fix set max frame size to default

In FreeBsd driver, the max frame size is changed to MTU, but not keep the default value defined in DataSheet. When DPDK runs on that NIC, the configured value is not expected.
This patch sets the max frame size to default when initialization.

Fixes: 4861cde46116 ("i40e: new poll mode driver")

Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
Acked-by: Helin Zhang <helin.zhang@intel.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] i40e: fix set max frame size to default
  2015-12-15 16:01 ` Zhang, Helin
@ 2015-12-15 16:23   ` Thomas Monjalon
  0 siblings, 0 replies; 3+ messages in thread
From: Thomas Monjalon @ 2015-12-15 16:23 UTC (permalink / raw)
  To: Wu, Jingjing; +Cc: dev, Dong, ShijieX

> In FreeBsd driver, the max frame size is changed to MTU, but not keep the default value defined in DataSheet. When DPDK runs on that NIC, the configured value is not expected.
> This patch sets the max frame size to default when initialization.
> 
> Fixes: 4861cde46116 ("i40e: new poll mode driver")
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>
> Acked-by: Helin Zhang <helin.zhang@intel.com>

Applied, thanks

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2015-12-15 16:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-12-15 14:52 [dpdk-dev] [PATCH] i40e: fix set max frame size to default Jingjing Wu
2015-12-15 16:01 ` Zhang, Helin
2015-12-15 16:23   ` Thomas Monjalon

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).