From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 1963F160 for ; Mon, 28 May 2018 00:01:18 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 88785219DA; Sun, 27 May 2018 18:01:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Sun, 27 May 2018 18:01:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=Se37oUN4JanZtpdQv/hpFt5sJ3 ivbow3zEn548EXtFA=; b=j70Yp85wSEdvf2PtljHDIn+2WnYkA3qDDpmRtoQb4u L1iX1tvuKxXUa+jHNpVklQ+vj+/vO8SXHNvWdB1gsCR3wU8lnRo6YY8fjx8q+Iz0 tluPZT/AyHiUnX7fLW7muqDi57dFB74pLPFjnU9dY/CEoDF13sV7yWN3Gx3pE6sB Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=Se37oU N4JanZtpdQv/hpFt5sJ3ivbow3zEn548EXtFA=; b=OOFyuJmNMlJWfpeWmUhNm5 Vykd1MVmyDXRlTQylsE+NltXHRzUs2vAVNyZzxee3epOAAyK66UB8IFZikvZYr4Q 7pVgQ/IEZIx44Thaqd1NavB0yZ8Qp/RSGTDXEHcfaRiq2RUoEWTFu8aIoXFI/cD5 1z84EYmhYD88HbbUqH9w8IuBWvrS6XUBdUo5QKhpByF128HSryY9NtiTcIZhnybZ hvn1Yy3UgYjuyHfCAVTKrrrrojymhB2+WCvbEvPg/PI5Lrf9AwcpgXldDw8kqDtp wet/MxfX0W8PO/i3TiXtUVmXVkPUvDkmHPA+TnjHcki16JynrifGPWuiAJasRBmA == X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id A3455E4119; Sun, 27 May 2018 18:01:16 -0400 (EDT) From: Thomas Monjalon To: Neil Horman Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com, Ferruh Yigit , Stephen Hemminger Date: Mon, 28 May 2018 00:01:15 +0200 Message-ID: <1614896.1p8jHt5N2x@xps> In-Reply-To: <20180527210039.GA22397@neilslaptop.think-freely.org> References: <20180115190545.25687-1-nhorman@tuxdriver.com> <1725451.L7JxISGBU9@xps> <20180527210039.GA22397@neilslaptop.think-freely.org> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v6] checkpatches.sh: Add checks for ABI symbol addition X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 27 May 2018 22:01:18 -0000 27/05/2018 23:00, Neil Horman: > On Sun, May 27, 2018 at 09:34:13PM +0200, Thomas Monjalon wrote: > > Hi Neil, > > > > Sorry, this patch has been forgotten during the whole release cycle. > > > Its ok, though that is frustrating, as we now need to re-familiarize ourselves > with how this patch works. I understand and apologize. > > I see an issue about the dependency on filterdiff. > > Is there a way to avoid it? > > > I suppose, but to do so would require some awk magic. Is there any advantage to > having an awk dependency rather than a filterdiff dependency? filterdiff is a > pretty universal tool. filterdiff is not installed on my machine. I guess it is the same for a lot of people. I will check how we can replace it. [...] > Fine, at this point, I don't know when I'll get to this though, its pretty busy > here at the moment. This delay is my fault, and I want to help. If I find a good solution, do you accept I send a version 7 of this patch?