From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com
 [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 3AC71A568
 for <dev@dpdk.org>; Sun, 21 Jan 2018 19:50:46 +0100 (CET)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id B415720B93;
 Sun, 21 Jan 2018 13:50:45 -0500 (EST)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Sun, 21 Jan 2018 13:50:45 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc; s=mesmtp; bh=9NP2iVkw4oOVKdX500FQxQL/yu
 MD3LlDeBKGdGew4kU=; b=EFB6yST64lOWTuZq6I2RP269oJKGYux9mydWKj0Tih
 vOX8wO4zT6FkI5meQjcUcTbpFVWC6uKAfuk+Pbkx3yUXDZnkF8sXqDHwFmNy7RCT
 rDOK5ccgbBAtzYpEZ50cjP3D7DeaDWs7umh8TXftPRdVuoFKpWIPwFnl25fX4Hlg
 0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9NP2iV
 kw4oOVKdX500FQxQL/yuMD3LlDeBKGdGew4kU=; b=rc1HIqDQnhjNV/Otmmraxg
 PB99OLzA96WKjnD7ULkksksjN+b722dTnpBCDqk5hjNPbDzIlLWdquRmbJ17lSAw
 kBmM0yFSpuNk245QReepHznn0+b86aSnplQUjG5xWWV7T3AorRHPXh4Z1CU+qCzX
 tCHgrwKGnDizDnwmMMCnLGYJqOkG3suJrIva74PbhFmV7ydt0BraBo4e3Nl0vvuE
 qELee3CbWn0tMF3MJf4p5nmSw5RewilcqxaaYZxRAeCPzSBrCfbwN/vFUil9bKE+
 yHdp4BxrTtcI4Pg2p0kT5qSGw8RSs/z2PkDj/ExRZn56I2u9WFLvjoCj+AwVq3nQ
 ==
X-ME-Sender: <xms:BeFkWoew7zgvlAmdGWC4DKYK0P1aVS0yLlJXQK0dQSlDCBSWoOd-tQ>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 4B4467E3DE;
 Sun, 21 Jan 2018 13:50:45 -0500 (EST)
From: Thomas Monjalon <thomas@monjalon.net>
To: Neil Horman <nhorman@tuxdriver.com>
Cc: dev@dpdk.org, john.mcnamara@intel.com, bruce.richardson@intel.com
Date: Sun, 21 Jan 2018 19:50:08 +0100
Message-ID: <16151335.JXrYqcJBJm@xps>
In-Reply-To: <20171213151728.16747-4-nhorman@tuxdriver.com>
References: <20171201185628.16261-1-nhorman@tuxdriver.com>
 <20171213151728.16747-1-nhorman@tuxdriver.com>
 <20171213151728.16747-4-nhorman@tuxdriver.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCHv4 3/5] Makefiles: Add experimental tag check
	and warnings to trigger on use
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Sun, 21 Jan 2018 18:50:46 -0000

13/12/2017 16:17, Neil Horman:
> --- a/lib/librte_eal/linuxapp/eal/Makefile
> +++ b/lib/librte_eal/linuxapp/eal/Makefile
> +CFLAGS += -DALLOW_EXPERIMENTAL_APIS

We can define this flag for the whole DPDK libraries,
	in mk/rte.vars.mk
	inside the block ifneq ($(BUILDING_RTE_SDK),)

> --- a/mk/internal/rte.compile-pre.mk
> +++ b/mk/internal/rte.compile-pre.mk
> +EXPERIMENTAL_CHECK = $(RTE_SDK)/buildtools/experimentalsyms.sh
> +CHECK_EXPERIMENTAL = $(EXPERIMENTAL_CHECK) $(SRCDIR)/$(EXPORT_MAP) $@

>  	echo $(C_TO_O_DISP); \
>  	$(C_TO_O) && \
>  	$(PMDINFO_TO_O) && \
> +	$(CHECK_EXPERIMENTAL) && \

Inserting this check looks good.