From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 16AD7A00C2; Wed, 17 Mar 2021 09:23:45 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 83D07242BB1; Wed, 17 Mar 2021 09:23:37 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id B65C3242B9F; Wed, 17 Mar 2021 09:23:35 +0100 (CET) IronPort-SDR: uVrnx/5NvqQdhYJawBCs3RVrqWOCyeA6se5K4J0zEfVXt/BwWLP6vUmmr0dDcwOy0V/F54aQpV vL1V0gpvH8bA== X-IronPort-AV: E=McAfee;i="6000,8403,9925"; a="189507890" X-IronPort-AV: E=Sophos;i="5.81,255,1610438400"; d="scan'208";a="189507890" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Mar 2021 01:23:35 -0700 IronPort-SDR: axUc/QoH1KFSg8f901ONK8y3v2PMDOpWn0w17SHr6bN4TgZGJ4WlULbj6xoPc+eJZuttcNEGkS V+RCILMmGkJQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.81,255,1610438400"; d="scan'208";a="605610976" Received: from unknown (HELO sh_lab5_1.sh.intel.com) ([10.238.175.190]) by fmsmga005.fm.intel.com with ESMTP; 17 Mar 2021 01:23:33 -0700 From: Wei Huang To: dev@dpdk.org, rosen.xu@intel.com, qi.z.zhang@intel.com Cc: stable@dpdk.org, tianfei.zhang@intel.com, Wei Huang Date: Wed, 17 Mar 2021 04:23:37 -0400 Message-Id: <1615969417-17118-3-git-send-email-wei.huang@intel.com> X-Mailer: git-send-email 1.8.3.1 In-Reply-To: <1615969417-17118-1-git-send-email-wei.huang@intel.com> References: <1615969417-17118-1-git-send-email-wei.huang@intel.com> Subject: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: add argument to use untained variable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" In fme_nios_spi_init(), passing tainted expression "fme->max10_dev" to function "fme_get_board_interface" has risk. Add new arguemnt in function "fme_get_board_interface" to accept untainted variable. Coverity issue: 367482 Fixes: 96ebfcf8125c ("raw/ifpga/base: add SPI and MAX10 device driver") Signed-off-by: Wei Huang --- drivers/raw/ifpga/base/ifpga_fme.c | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/drivers/raw/ifpga/base/ifpga_fme.c b/drivers/raw/ifpga/base/ifpga_fme.c index a63f90331f..4edb9e09e1 100644 --- a/drivers/raw/ifpga/base/ifpga_fme.c +++ b/drivers/raw/ifpga/base/ifpga_fme.c @@ -857,7 +857,8 @@ static int board_type_to_info(u32 type, return 0; } -static int fme_get_board_interface(struct ifpga_fme_hw *fme) +static int fme_get_board_interface(struct ifpga_fme_hw *fme, + struct intel_max10_device *max10_dev) { struct fme_bitstream_id id; struct ifpga_hw *hw; @@ -911,15 +912,15 @@ static int fme_get_board_interface(struct ifpga_fme_hw *fme) fme->board_info.nums_of_fvl, fme->board_info.ports_per_fvl); - if (max10_sys_read(fme->max10_dev, FPGA_PAGE_INFO, &val)) + if (max10_sys_read(max10_dev, FPGA_PAGE_INFO, &val)) return -EINVAL; fme->board_info.boot_page = val & 0x7; - if (max10_sys_read(fme->max10_dev, MAX10_BUILD_VER, &val)) + if (max10_sys_read(max10_dev, MAX10_BUILD_VER, &val)) return -EINVAL; fme->board_info.max10_version = val; - if (max10_sys_read(fme->max10_dev, NIOS2_FW_VERSION, &val)) + if (max10_sys_read(max10_dev, NIOS2_FW_VERSION, &val)) return -EINVAL; fme->board_info.nios_fw_version = val; @@ -1169,7 +1170,7 @@ static int fme_nios_spi_init(struct ifpga_feature *feature) max10->bus = hw->pci_data->bus; - fme_get_board_interface(fme); + fme_get_board_interface(fme, max10); mgr->sensor_list = &max10->opae_sensor_list; @@ -1186,7 +1187,7 @@ static int fme_nios_spi_init(struct ifpga_feature *feature) return ret; spi_fail: - intel_max10_device_remove(fme->max10_dev); + intel_max10_device_remove(max10); release_dev: altera_spi_release(spi_master); return -ENODEV; -- 2.29.2