From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f41.google.com (mail-wm0-f41.google.com [74.125.82.41]) by dpdk.org (Postfix) with ESMTP id B3DC92C19 for ; Wed, 25 May 2016 18:04:16 +0200 (CEST) Received: by mail-wm0-f41.google.com with SMTP id n129so190016899wmn.1 for ; Wed, 25 May 2016 09:04:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=In914em6WD85kcJ13ne4DxVZOKHkTXMhQEApE6VtASI=; b=fVx6jdOIIBGcDmS8nMxZf4POQ+MxiBaBPpqQjFsdR2qKBapuhlDxKHj0oiluDFDtVb tv6SKVErO3I/bQ6fVJZ5BX683sbCLcS33OvMJ/RPvCLN0qpCWtxX+FnW1B3Bn6gcO/54 Z6kGrs9LGM5FuZdHNquebv32shSg9qkWljHoLQUGrllYuce6T7W647iMK5XctXjPrbBD MnzSK7SMPk4g80g9w0ujmuQx7RmfbOwuipn3XH9kIzGv+y3CJ23AP4lRllvZ5U9fOPvn 6AlB/abotjIWvkiwlvuD4TAqCDPbaqS9YcnJkfDGxUXWRKd18w8XkPfvDtl6HGETiuIK E6Wg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=In914em6WD85kcJ13ne4DxVZOKHkTXMhQEApE6VtASI=; b=MMDNC5rcr9nXakUhMYbwf6NHqQU3q3wcLi/gGzrXmprwdz/n7+yvm9UEkfMPpJH/o/ kbVy+brRnEwBARvS2ndJA+Yxdhm+vhlKYoylmgJWapjkW0r3L8VTTYjWQ+1YvKgYNL5L X2yRhKmm8eSNQjeX3ZRQsR4Iy3QoXeDXwKqMIAK6BifgXPvXNKjl8GL3UM5xu5N3jmB6 KXHXIPFB68RwBBSQkSKT57uprgQYAcyr1FhUsOV7KF3qEHdSuyp+Dj53h7kTNagn86Iw fu0z7cm8+BOgrxYAyakuLSh1CXJdm+3+O/bi2N6Xl+qylIv7PjQddyhEqf+PL/COdKIf tIyg== X-Gm-Message-State: ALyK8tKv2mwE11/k7QrwePPuiNNF4+brIfLuIcGOQnGVpv20+araNfhyhjyh8VZadqwinTU7 X-Received: by 10.28.145.73 with SMTP id t70mr4243190wmd.97.1464192256359; Wed, 25 May 2016 09:04:16 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id e8sm10131490wma.2.2016.05.25.09.04.15 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 25 May 2016 09:04:15 -0700 (PDT) From: Thomas Monjalon To: Hiroyuki Mikita Cc: wenzhuo.lu@intel.com, dev@dpdk.org Date: Wed, 25 May 2016 18:04:14 +0200 Message-ID: <1617188.mGNhOEY9vJ@xps13> User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <1464189938-1769-1-git-send-email-h.mikita89@gmail.com> References: <1464101290-28547-1-git-send-email-h.mikita89@gmail.com> <1464189938-1769-1-git-send-email-h.mikita89@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH v2] e1000: fix build with clang X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 May 2016 16:04:16 -0000 2016-05-26 00:25, Hiroyuki Mikita: > GCC_VERSION is empty in case of clang: > /bin/sh: line 0: test: -ge: unary operator expected > > It is the same issue as http://dpdk.org/dev/patchwork/patch/5994/ > > Fixes: 366113dbfb69 ("e1000: suppress misleading indentation warning") > > Signed-off-by: Hiroyuki Mikita > --- > v2: > * fix for cross compier The output of git grep '(CC)' shows that there is some room for cross-compilation fixes. Any volunteer? > +ifeq ($(findstring gcc, $(CC)), gcc) > ifeq ($(shell test $(GCC_VERSION) -ge 60 && echo 1), 1) Looks good, thanks