From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <thomas@monjalon.net> Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by dpdk.org (Postfix) with ESMTP id 535B22B87 for <dev@dpdk.org>; Fri, 1 Mar 2019 22:13:05 +0100 (CET) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id EE8CC21F35; Fri, 1 Mar 2019 16:13:04 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Fri, 01 Mar 2019 16:13:04 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=jcWge+ynBh8qVdbYR6S+y2h+/iCnHf8WZ41ywT5CF+s=; b=KAg+QqeEXSR8 qPtlHxDQL2Wo73AkHItdLGTbJvKkfR/iXh/tFeGQkYtoEwaaIFe42ES9MESFsJDh OtlsjfDcE5BACffQxOlzvQeDwpW0FDP+s+0tkXSJ5anybq+XPP7Qs6HfNXz7ZChJ 5v9Z8kb0cuQ/ftGBdE4JGNxWyB7CGmk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=jcWge+ynBh8qVdbYR6S+y2h+/iCnHf8WZ41ywT5CF +s=; b=C41GRqd3qP7uclSLrVy6S4UaoIB984Q4dDttbE4jJBQA7WjprBLU6f24C x1QShBoWT02gRk66Ytljm8LRi0FRsePoAjQxrpPxsTXV4DPw3oG1FLrM8Rieh7E3 Dq9t1+eD3VURteSzyJ1pmTm9D37I7WlZiFdqs3zB9fBdPcy/CM7NKqakZFwT+ntJ u7f4XXM/niBR7+LR4Y7e57TsiuZA1F4M58wg3b4h2ASTYlIW/Y6ERIXXCcbmSwoM TyLS6v58zHUdYADLuFcKIK4saZFZSbGYUXHoBiWNM4PxORdItHDV1wmUbr7wSJNl 4OsZtDaof8UcdRfADkzNUWtCRu2XQ== X-ME-Sender: <xms:X6B5XMSJyXIpSKNVVgXuf5GoQvuE4wQYxcJzVhA24f8LtSg7NNKdsQ> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedutddrvdehgddugeejucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucfrrghrrghmpehmrghilhhfrhhomhepthhh ohhmrghssehmohhnjhgrlhhonhdrnhgvthenucevlhhushhtvghrufhiiigvpedt X-ME-Proxy: <xmx:X6B5XAEEBL_QO5fqWz2jMLMTEIiSE6_32UbqcnExUtcwzM1AVHG5UQ> <xmx:X6B5XGjxcpU741vkrk7XY4CcHHoS1SiGJMxlwExEyne7FN-5_K3HPw> <xmx:X6B5XOqxa5pFO_HimMhqqgs-aNGeVyD-3Y8twGDHlBfR_C3rQvuALQ> <xmx:YKB5XN_v6sc6BCSEVTubjpd4FBQcW2x_AEjDjZwOzC16oTVo1PPCVw> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 4AAACE427E; Fri, 1 Mar 2019 16:12:59 -0500 (EST) From: Thomas Monjalon <thomas@monjalon.net> To: "Eads, Gage" <gage.eads@intel.com> Cc: Olivier Matz <olivier.matz@6wind.com>, "dev@dpdk.org" <dev@dpdk.org>, "arybchenko@solarflare.com" <arybchenko@solarflare.com>, "Richardson, Bruce" <bruce.richardson@intel.com>, "Ananyev, Konstantin" <konstantin.ananyev@intel.com>, "gavin.hu@arm.com" <gavin.hu@arm.com>, "Honnappa.Nagarahalli@arm.com" <Honnappa.Nagarahalli@arm.com>, "nd@arm.com" <nd@arm.com> Date: Fri, 01 Mar 2019 22:12:53 +0100 Message-ID: <16181918.9taCLPWhEn@xps> In-Reply-To: <9184057F7FC11744A2107296B6B8EB1E541EE3BD@FMSMSX108.amr.corp.intel.com> References: <20190222160655.3346-1-gage.eads@intel.com> <2EC44CCD3517A842B44C82651A5557A14AF13386@fmsmsx118.amr.corp.intel.com> <9184057F7FC11744A2107296B6B8EB1E541EE3BD@FMSMSX108.amr.corp.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] FW: [PATCH 5/7] stack: add non-blocking stack implementation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 01 Mar 2019 21:13:05 -0000 01/03/2019 21:53, Eads, Gage: > From: Olivier Matz [mailto:olivier.matz@6wind.com] > > On Fri, Feb 22, 2019 at 10:06:53AM -0600, Gage Eads wrote: > > > +#define STACK_F_NB 0x0001 > > > > What about adding the RTE_ prefix? > > I'm fine with either, but there's precedent for flag macros named > <module_name>_*. E.g. RING_F_*, MEMPOOL_F_*, ETH_*, and SERVICE_F_*. They should be fixed. Every public symbols should be prefixed to avoid namespace conflict. At first, we should rename them and keep the old name as an alias. Later, non-prefixed names should be removed after a deprecation notice.