From: Thomas Monjalon <thomas@monjalon.net>
To: Bruce Richardson <bruce.richardson@intel.com>
Cc: Andrey Vesnovaty <andrey.vesnovaty@gmail.com>,
dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>,
Andrew Rybchenko <arybchenko@solarflare.com>,
Ori Kam <orika@mellanox.com>
Subject: Re: [dpdk-dev] [RFC] add flow action context API
Date: Fri, 05 Jun 2020 10:33:53 +0200 [thread overview]
Message-ID: <1618422.q0uPWd4TDI@thomas> (raw)
In-Reply-To: <20200605083035.GA1552@bricha3-MOBL.ger.corp.intel.com>
05/06/2020 10:30, Bruce Richardson:
> On Thu, Jun 04, 2020 at 07:23:04PM +0200, Thomas Monjalon wrote:
> > 04/06/2020 13:12, Andrey Vesnovaty:
> > > Thomas Monjalon <thomas@monjalon.net> wrote:
> > > > 20/05/2020 11:18, Andrey Vesnovaty:
> > > > We had "create", "destroy", "query", but no "modify" capability.
> > > > The new API is adding 2 things in my opinion:
> > > > - shared action object
> > > > - "modify" capability (is "update" a better wording?)
> > >
> > > Naming is one of the most challenging parts of this RFC.
> > > Some similarity I have found in existing code is
> > > rte_mtr_policer_actions_update()
> > > Is there any existing code having update/modify semantics?
> >
> > Except one callback in librte_fib, no DPDK API has "modify" in its name.
> > You can find the word "update" in the API of multiple DPDK libs.
> > I would like having the opinion of a native english speaker here.
> >
> From a language viewpoint either is fine for conveying what the API does.
> In this case "update" would seem to be better for consistency reasons.
OK, thank you Bruce
next prev parent reply other threads:[~2020-06-05 8:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-20 9:18 Andrey Vesnovaty
2020-06-03 10:02 ` Thomas Monjalon
2020-06-04 11:12 ` Andrey Vesnovaty
2020-06-04 17:23 ` Thomas Monjalon
2020-06-05 8:30 ` Bruce Richardson
2020-06-05 8:33 ` Thomas Monjalon [this message]
2020-06-03 10:53 ` Jerin Jacob
2020-06-04 11:25 ` Andrey Vesnovaty
2020-06-04 12:36 ` Jerin Jacob
2020-06-04 15:57 ` Andrey Vesnovaty
2020-06-09 16:01 ` Jerin Jacob
2020-06-20 13:32 ` [dpdk-dev] [RFC v2 0/1] " Andrey Vesnovaty
2020-06-22 15:22 ` Thomas Monjalon
2020-06-22 17:09 ` Andrey Vesnovaty
2020-06-26 11:44 ` Jerin Jacob
2020-06-28 8:44 ` Andrey Vesnovaty
2020-06-28 13:42 ` Jerin Jacob
2020-06-29 10:22 ` Andrey Vesnovaty
2020-06-30 9:52 ` Jerin Jacob
2020-07-01 9:24 ` Andrey Vesnovaty
2020-07-01 10:34 ` Jerin Jacob
2020-06-20 13:32 ` [dpdk-dev] [RFC v2 1/1] add flow shared action API Andrey Vesnovaty
2020-07-02 0:24 ` Stephen Hemminger
2020-07-02 7:20 ` Ori Kam
2020-07-02 8:06 ` Andrey Vesnovaty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1618422.q0uPWd4TDI@thomas \
--to=thomas@monjalon.net \
--cc=andrey.vesnovaty@gmail.com \
--cc=arybchenko@solarflare.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=orika@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).