From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 3C7FA1B13F for ; Thu, 4 Oct 2018 11:48:34 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id C3F6B21ACF; Thu, 4 Oct 2018 05:48:33 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 04 Oct 2018 05:48:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=HQOXZH8IM7mirbvVmzG6TWJd35GuTjmQs9blbZjqBmU=; b=o/KPS/AbX344 Ml1qthiojnLFlIPYHvXuAjDq7zLSpZIA68yYoBNvtjLMQEsgilzB90QctPbgixTS 1kt/7LMYU0B7IuHvt+TgsinKgJirWDbBmXswDIUs/1LZxebi3LZGzHthZkQCjoNT BtVSFEzevJ7kxVz6zo5pvVf6ELxXi50= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=HQOXZH8IM7mirbvVmzG6TWJd35GuTjmQs9blbZjqB mU=; b=UiMmxrJYxhJXBajrzxtXOIBK27vwfWN5vCOEFm8SZzNMHrAiIaNMPm5fU WVL3d0dZLupJ305mHgg10WpLjUKWsXGIjGC05A01JKDJbU10lKmePN2z2rkhrLcN asfyJVrY6sQUTfgCgoGBJaZP6EEX/M8pQIdATDdgUKyz/YSFbEVHCAIvITk2KGfF e3A3CksjXpv2X47FHo0THhMe8UVM1KU10hzmot/UXF+tFAcpYYCpIt/om9oQUzPW 9ZuMVhojfPci0WU3oiGONWP9XkOMmIwpudQVwqitAAcfmk2OZHs5vHVuCFSUJirN 0dlWRsCUKeOkZSVWiqcYXYq2KbP6A== X-ME-Sender: X-ME-Proxy: Received: from xps.localnet (106.86.136.77.rev.sfr.net [77.136.86.106]) by mail.messagingengine.com (Postfix) with ESMTPA id 52357102D3; Thu, 4 Oct 2018 05:48:30 -0400 (EDT) From: Thomas Monjalon To: =?ISO-8859-1?Q?Ga=EBtan?= Rivet Cc: dev@dpdk.org, ophirmu@mellanox.com, qi.z.zhang@intel.com, ferruh.yigit@intel.com, ktraynor@redhat.com, Rosen Xu , Hemant Agrawal , Shreyansh Jain , Stephen Hemminger Date: Thu, 04 Oct 2018 11:48:27 +0200 Message-ID: <1618584.QBlmI0xGr4@xps> In-Reply-To: <20181004093108.hfe7xmaubatg4ooz@bidouze.vm.6wind.com> References: <20180907222727.20521-1-thomas@monjalon.net> <20181003231046.26772-4-thomas@monjalon.net> <20181004093108.hfe7xmaubatg4ooz@bidouze.vm.6wind.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" Subject: Re: [dpdk-dev] [PATCH v5 3/5] eal: add bus pointer in device structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 04 Oct 2018 09:48:34 -0000 04/10/2018 11:31, Ga=EBtan Rivet: > On Thu, Oct 04, 2018 at 01:10:44AM +0200, Thomas Monjalon wrote: > > When a device is added with a devargs (hotplug or whitelist), > > the bus pointer can be retrieved via its devargs. > > But there is no such devargs.bus in case of standard scan. > >=20 > > A pointer to the rte_bus handle is added to rte_device. > > When a device is allocated (during a scan), > > the pointer to its bus is assigned. > >=20 > > It will make possible to remove a rte_device, > > using the function pointer from its bus. > >=20 > > The function rte_bus_find_by_device() becomes useless, > > and may be removed later. > >=20 > > Signed-off-by: Thomas Monjalon >=20 > I agree with this change, but I think this can break ABI of > buses defining their structure by composition with rte_device (e.g. PCI > bus). Have you checked ABI? Yes I forgot it changes the size of the bus structures. I can spin a v6 with a bump of ABI version of the bus drivers, and an additional note in release notes. > Personally I don't care, I prefer a clean framework to a littered lib. >=20 > Acked-by: Gaetan Rivet Adding bus drivers maintainers to get more opinions.