[dpdk-dev] [PATCH 0/2] fixes for i40e PMD

[dpdk-dev] [PATCH 0/2] fixes for i40e PMD

[Min Hu (Connor)]

This patchset contains two fixes for i40e PMD.

Chengwen Feng (2):
  net/i40e: fix veb index negative was not checked
  net/i40e: remove redundant judgment

 drivers/net/i40e/i40e_ethdev.c | 2 ++
 drivers/net/i40e/i40e_rxtx.c   | 2 --
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.4

[dpdk-dev] [PATCH 1/2] net/i40e: fix veb index negative was not checked

[Min Hu (Connor)]

From: Chengwen Feng <fengchengwen@huawei.com>

This patch adds checking for veb index negative when parsing veb list.

Fixes: 79f2248219c0 (net/i40e: add floating VEB option)
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 drivers/net/i40e/i40e_ethdev.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethdev.c
index e6206a7..c897c81 100644
--- a/drivers/net/i40e/i40e_ethdev.c
+++ b/drivers/net/i40e/i40e_ethdev.c
@@ -854,6 +854,8 @@ floating_veb_list_handler(__rte_unused const char *key,
 		idx = strtoul(floating_veb_value, &end, 10);
 		if (errno || end == NULL)
 			return -1;
+		if (idx < 0)
+			return -1;
 		while (isblank(*end))
 			end++;
 		if (*end == '-') {
-- 
2.7.4

Re: [dpdk-dev] [PATCH 1/2] net/i40e: fix veb index negative was not checked

[Zhang, Qi Z]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Min Hu (Connor)
> Sent: Wednesday, April 21, 2021 10:33 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Guo, Jia <jia.guo@intel.com>
> Subject: [dpdk-dev] [PATCH 1/2] net/i40e: fix veb index negative was not
> checked
> 
> From: Chengwen Feng <fengchengwen@huawei.com>
> 
> This patch adds checking for veb index negative when parsing veb list.
> 
> Fixes: 79f2248219c0 (net/i40e: add floating VEB option)
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

[dpdk-dev] [PATCH 2/2] net/i40e: remove redundant judgment

[Min Hu (Connor)]

From: Chengwen Feng <fengchengwen@huawei.com>

The vsi pointer is always valid, so it no need to judge it's validity.

Fixes: b6583ee40265 ("i40e: full VMDQ pools support")
Cc: stable@dpdk.org

Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 drivers/net/i40e/i40e_rxtx.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c
index 3c7686c..064b765 100644
--- a/drivers/net/i40e/i40e_rxtx.c
+++ b/drivers/net/i40e/i40e_rxtx.c
@@ -2216,8 +2216,6 @@ i40e_dev_tx_queue_setup(struct rte_eth_dev *dev,
 	if (hw->mac.type == I40E_MAC_VF || hw->mac.type == I40E_MAC_X722_VF) {
 		vf = I40EVF_DEV_PRIVATE_TO_VF(dev->data->dev_private);
 		vsi = &vf->vsi;
-		if (!vsi)
-			return -EINVAL;
 		reg_idx = queue_idx;
 	} else {
 		pf = I40E_DEV_PRIVATE_TO_PF(dev->data->dev_private);
-- 
2.7.4

Re: [dpdk-dev] [PATCH 2/2] net/i40e: remove redundant judgment

[Zhang, Qi Z]

> -----Original Message-----
> From: dev <dev-bounces@dpdk.org> On Behalf Of Min Hu (Connor)
> Sent: Wednesday, April 21, 2021 10:33 AM
> To: dev@dpdk.org
> Cc: Yigit, Ferruh <ferruh.yigit@intel.com>; Xing, Beilei <beilei.xing@intel.com>;
> Guo, Jia <jia.guo@intel.com>
> Subject: [dpdk-dev] [PATCH 2/2] net/i40e: remove redundant judgment
> 
> From: Chengwen Feng <fengchengwen@huawei.com>
> 
> The vsi pointer is always valid, so it no need to judge it's validity.
> 
> Fixes: b6583ee40265 ("i40e: full VMDQ pools support")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi