From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>, <bernard.iremonger@intel.com>
Subject: [dpdk-dev] [PATCH] test: fix flow classifier creating failure
Date: Thu, 22 Apr 2021 14:13:54 +0800 [thread overview]
Message-ID: <1619072034-36817-1-git-send-email-humin29@huawei.com> (raw)
'cls->cls' will be NULL if flow classifier create has failed,
then segmentation fault will occur if the variable is used.
This patch fixed it.
Fixes: 9c9befea4f57 ("test: add flow classify unit tests")
Cc: stable@dpdk.org
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
app/test/test_flow_classify.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c
index ef0b6fd..951606f 100644
--- a/app/test/test_flow_classify.c
+++ b/app/test/test_flow_classify.c
@@ -828,6 +828,12 @@ test_flow_classify(void)
cls_params.name = "flow_classifier";
cls_params.socket_id = 0;
cls->cls = rte_flow_classifier_create(&cls_params);
+ if (cls->cls == NULL) {
+ printf("Line %i: flow classifier create has failed!\n",
+ __LINE__);
+ rte_free(cls);
+ return TEST_FAILED;
+ }
/* initialise ACL table params */
table_acl_params.n_rule_fields = RTE_DIM(ipv4_defs);
--
2.7.4
next reply other threads:[~2021-04-22 6:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 6:13 Min Hu (Connor) [this message]
2021-04-22 9:51 ` Iremonger, Bernard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619072034-36817-1-git-send-email-humin29@huawei.com \
--to=humin29@huawei.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).