From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C90C3A09E4; Thu, 22 Apr 2021 08:13:53 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7E979413FA; Thu, 22 Apr 2021 08:13:53 +0200 (CEST) Received: from szxga05-in.huawei.com (szxga05-in.huawei.com [45.249.212.191]) by mails.dpdk.org (Postfix) with ESMTP id 47D66413E6 for ; Thu, 22 Apr 2021 08:13:52 +0200 (CEST) Received: from DGGEMS406-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4FQn9k6jwZzrfP9 for ; Thu, 22 Apr 2021 14:11:22 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS406-HUB.china.huawei.com (10.3.19.206) with Microsoft SMTP Server id 14.3.498.0; Thu, 22 Apr 2021 14:13:42 +0800 From: "Min Hu (Connor)" To: CC: , Date: Thu, 22 Apr 2021 14:13:54 +0800 Message-ID: <1619072034-36817-1-git-send-email-humin29@huawei.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH] test: fix flow classifier creating failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 'cls->cls' will be NULL if flow classifier create has failed, then segmentation fault will occur if the variable is used. This patch fixed it. Fixes: 9c9befea4f57 ("test: add flow classify unit tests") Cc: stable@dpdk.org Signed-off-by: Min Hu (Connor) --- app/test/test_flow_classify.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/app/test/test_flow_classify.c b/app/test/test_flow_classify.c index ef0b6fd..951606f 100644 --- a/app/test/test_flow_classify.c +++ b/app/test/test_flow_classify.c @@ -828,6 +828,12 @@ test_flow_classify(void) cls_params.name = "flow_classifier"; cls_params.socket_id = 0; cls->cls = rte_flow_classifier_create(&cls_params); + if (cls->cls == NULL) { + printf("Line %i: flow classifier create has failed!\n", + __LINE__); + rte_free(cls); + return TEST_FAILED; + } /* initialise ACL table params */ table_acl_params.n_rule_fields = RTE_DIM(ipv4_defs); -- 2.7.4