[dpdk-dev] [PATCH 0/2] bugfix for hns3 PMD

[dpdk-dev] [PATCH 0/2] bugfix for hns3 PMD

[Min Hu (Connor)]

This patch set contains two bugfixes for hns3 PMD.

Min Hu (Connor) (2):
  net/hns3: fix wrong word of comments
  doc: fix runtime config options

 doc/guides/nics/hns3.rst       |  9 +++++++++
 drivers/net/hns3/hns3_ethdev.c | 10 +++++-----
 2 files changed, 14 insertions(+), 5 deletions(-)

-- 
2.7.4

[dpdk-dev] [PATCH 1/2] net/hns3: fix wrong word of comments

[Min Hu (Connor)]

This patch fixed wrong word in comments.

Fixes: f53a793bb7c2 ("net/hns3: add more hardware error types")
Fixes: d51867db65c1 ("net/hns3: add initialization")
Fixes: 411d23b9eafb ("net/hns3: support VLAN")
Fixes: 5f8845f4ba8f ("net/hns3: process MAC interrupt")
Cc: stable@dpdk.org

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 drivers/net/hns3/hns3_ethdev.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 60267e1..16ee4ac 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -280,7 +280,7 @@ hns3_handle_mac_tnl(struct hns3_hw *hw)
 	uint32_t status;
 	int ret;
 
-	/* query and clear mac tnl interruptions */
+	/* query and clear mac tnl interrupt */
 	hns3_cmd_setup_basic_desc(&desc, HNS3_OPC_QUERY_MAC_TNL_INT, true);
 	ret = hns3_cmd_send(hw, &desc, 1);
 	if (ret) {
@@ -462,7 +462,7 @@ hns3_vlan_filter_configure(struct hns3_adapter *hns, uint16_t vlan_id, int on)
 	 * When port base vlan enabled, we use port base vlan as the vlan
 	 * filter condition. In this case, we don't update vlan filter table
 	 * when user add new vlan or remove exist vlan, just update the
-	 * vlan list. The vlan id in vlan list will be writen in vlan filter
+	 * vlan list. The vlan id in vlan list will be written in vlan filter
 	 * table until port base vlan disabled
 	 */
 	if (hw->port_base_vlan_cfg.state == HNS3_PORT_BASE_VLAN_DISABLE) {
@@ -3983,8 +3983,8 @@ hns3_rx_buffer_calc(struct hns3_hw *hw, struct hns3_pkt_buf_alloc *buf_alloc)
 	 * For different application scenes, the enabled port number, TC number
 	 * and no_drop TC number are different. In order to obtain the better
 	 * performance, software could allocate the buffer size and configure
-	 * the waterline by tring to decrease the private buffer size according
-	 * to the order, namely, waterline of valided tc, pfc disabled tc, pfc
+	 * the waterline by trying to decrease the private buffer size according
+	 * to the order, namely, waterline of valid tc, pfc disabled tc, pfc
 	 * enabled tc.
 	 */
 	if (hns3_rx_buf_calc_all(hw, false, buf_alloc))
@@ -5045,7 +5045,7 @@ hns3_config_all_msix_error(struct hns3_hw *hw, bool enable)
 	 * and belong to a different type from the MSI-x errors processed
 	 * by the network driver.
 	 *
-	 * Network driver should open the new error report on initialition
+	 * Network driver should open the new error report on initialization.
 	 */
 	val = hns3_read_dev(hw, HNS3_VECTOR0_OTER_EN_REG);
 	hns3_set_bit(val, HNS3_VECTOR0_ALL_MSIX_ERR_B, enable ? 1 : 0);
-- 
2.7.4

[dpdk-dev] [PATCH 2/2] doc: fix runtime config options

[Min Hu (Connor)]

This patch added examples for runtime config options, to help user
how to use this.

Fixes: a124f9e9591b ("net/hns3: add runtime config to select IO burst function")
Fixes: 70791213242e ("net/hns3: support masking device capability")

Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
 doc/guides/nics/hns3.rst | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/doc/guides/nics/hns3.rst b/doc/guides/nics/hns3.rst
index 52d6718..d51d9b1 100644
--- a/doc/guides/nics/hns3.rst
+++ b/doc/guides/nics/hns3.rst
@@ -67,6 +67,9 @@ Runtime Config Options
   be first checked, if meets, use the ``vec``. Then, ``simple``, at last
   ``common``.
 
+  For example::
+  -a 0000:7d:00.0,rx_func_hint=simple
+
 - ``tx_func_hint`` (default ``none``)
 
   Used to select Tx burst function, supported value are ``vec``, ``sve``,
@@ -84,6 +87,9 @@ Runtime Config Options
   be first checked, if meets, use the ``vec``. Then, ``simple``, at last
   ``common``.
 
+  For example::
+  -a 0000:7d:00.0,tx_func_hint=common
+
 - ``dev_caps_mask`` (default ``0``)
 
   Used to mask the capability which queried from firmware.
@@ -93,6 +99,9 @@ Runtime Config Options
   masked off, then the capability will be 0xFFF0.
   Its main purpose is to debug and avoid problems.
 
+  For example::
+  -a 0000:7d:00.0,dev_caps_mask=0xF
+
 Driver compilation and testing
 ------------------------------
 
-- 
2.7.4

Re: [dpdk-dev] [PATCH 0/2] bugfix for hns3 PMD

[Ferruh Yigit]

On 4/23/2021 10:27 AM, Min Hu (Connor) wrote:
> This patch set contains two bugfixes for hns3 PMD.
> 
> Min Hu (Connor) (2):
>   net/hns3: fix wrong word of comments
>   doc: fix runtime config options
> 

Series applied to dpdk-next-net/main, thanks.