From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH v2] net/hns3: fix parse link fails code fail
Date: Mon, 26 Apr 2021 21:42:28 +0800 [thread overview]
Message-ID: <1619444548-24977-1-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1619056552-43937-4-git-send-email-humin29@huawei.com>
From: Chengwen Feng <fengchengwen@huawei.com>
The link fails code should be parsed using the structure
hns3_mbx_vf_to_pf_cmd, else it will parse fail.
Fixes: 109e4dd1bd7a ("net/hns3: get link state change through mailbox")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
v2:
* kept original API interface.
---
drivers/net/hns3/hns3_mbx.c | 10 +++++++++-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/hns3/hns3_mbx.c b/drivers/net/hns3/hns3_mbx.c
index eb202dd..755298f 100644
--- a/drivers/net/hns3/hns3_mbx.c
+++ b/drivers/net/hns3/hns3_mbx.c
@@ -346,12 +346,20 @@ hns3_link_fail_parse(struct hns3_hw *hw, uint8_t link_fail_code)
}
static void
+
hns3pf_handle_link_change_event(struct hns3_hw *hw,
- struct hns3_mbx_pf_to_vf_cmd *req)
+ struct hns3_mbx_pf_to_vf_cmd *cmd)
{
#define LINK_STATUS_OFFSET 1
#define LINK_FAIL_CODE_OFFSET 2
+ /*
+ * This message is reported by the firmware and is reported in
+ * 'struct hns3_mbx_vf_to_pf_cmd' format. Therefore, we should cast
+ * the cmd to 'struct hns3_mbx_vf_to_pf_cmd' first.
+ */
+ struct hns3_mbx_vf_to_pf_cmd *req = (struct hns3_mbx_vf_to_pf_cmd *)cmd;
+
if (!req->msg[LINK_STATUS_OFFSET])
hns3_link_fail_parse(hw, req->msg[LINK_FAIL_CODE_OFFSET]);
--
2.7.4
next prev parent reply other threads:[~2021-04-26 13:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-22 1:55 [dpdk-dev] [PATCH 0/4] bugfix for hns3 PMD Min Hu (Connor)
2021-04-22 1:55 ` [dpdk-dev] [PATCH 1/4] net/hns3: fix error mbx messages prompt errors Min Hu (Connor)
2021-04-22 1:55 ` [dpdk-dev] [PATCH 2/4] net/hns3: fix PF miss link status notify message Min Hu (Connor)
2021-04-22 1:55 ` [dpdk-dev] [PATCH 3/4] net/hns3: fix parse link fails code fail Min Hu (Connor)
2021-04-26 12:26 ` Ferruh Yigit
2021-04-26 12:41 ` fengchengwen
2021-04-26 12:50 ` Ferruh Yigit
2021-04-26 13:20 ` fengchengwen
2021-04-26 13:42 ` Min Hu (Connor) [this message]
2021-04-27 11:11 ` [dpdk-dev] [PATCH v2] " Ferruh Yigit
2021-04-27 12:31 ` Min Hu (Connor)
2021-04-27 12:17 ` [dpdk-dev] [PATCH v3] " Min Hu (Connor)
2021-04-27 12:45 ` Ferruh Yigit
2021-04-27 13:03 ` Min Hu (Connor)
2021-04-27 13:19 ` Ferruh Yigit
2021-04-27 13:43 ` Min Hu (Connor)
2021-04-27 15:09 ` Ferruh Yigit
2021-04-22 1:55 ` [dpdk-dev] [PATCH 4/4] net/hns3: delete unused macro and struct of mbx module Min Hu (Connor)
2021-04-26 12:52 ` [dpdk-dev] [PATCH 0/4] bugfix for hns3 PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1619444548-24977-1-git-send-email-humin29@huawei.com \
--to=humin29@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).