* [dpdk-dev] [PATCH 0/2] bugfix for lib eventdev
@ 2021-04-30 9:34 Min Hu (Connor)
2021-04-30 9:34 ` [dpdk-dev] [PATCH 1/2] eventdev: remove redundant setting thread name Min Hu (Connor)
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Min Hu (Connor) @ 2021-04-30 9:34 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, jerinj
This patch set contains two bugfixes for lib eventdev.
Chengwen Feng (2):
eventdev: remove redundant setting thread name
eventdev: fix memory leakage when create thread fail
lib/eventdev/rte_event_eth_rx_adapter.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread* [dpdk-dev] [PATCH 1/2] eventdev: remove redundant setting thread name
2021-04-30 9:34 [dpdk-dev] [PATCH 0/2] bugfix for lib eventdev Min Hu (Connor)
@ 2021-04-30 9:34 ` Min Hu (Connor)
2021-05-01 12:38 ` Jerin Jacob
2021-04-30 9:34 ` [dpdk-dev] [PATCH 2/2] eventdev: fix memory leakage when create thread fail Min Hu (Connor)
2021-04-30 15:35 ` [dpdk-dev] [EXT] [PATCH 0/2] bugfix for lib eventdev Pavan Nikhilesh Bhagavatula
2 siblings, 1 reply; 7+ messages in thread
From: Min Hu (Connor) @ 2021-04-30 9:34 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, jerinj
From: Chengwen Feng <fengchengwen@huawei.com>
The thread name already set by rte_ctrl_thread_create() API, so remove
the call of rte_thread_setname() API.
Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
lib/eventdev/rte_event_eth_rx_adapter.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index ca166a6..d317e89 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -1432,10 +1432,8 @@ rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter)
err = rte_ctrl_thread_create(&rx_adapter->rx_intr_thread, thread_name,
NULL, rxa_intr_thread, rx_adapter);
- if (!err) {
- rte_thread_setname(rx_adapter->rx_intr_thread, thread_name);
+ if (!err)
return 0;
- }
RTE_EDEV_LOG_ERR("Failed to create interrupt thread err = %d\n", err);
error:
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH 1/2] eventdev: remove redundant setting thread name
2021-04-30 9:34 ` [dpdk-dev] [PATCH 1/2] eventdev: remove redundant setting thread name Min Hu (Connor)
@ 2021-05-01 12:38 ` Jerin Jacob
0 siblings, 0 replies; 7+ messages in thread
From: Jerin Jacob @ 2021-05-01 12:38 UTC (permalink / raw)
To: Min Hu (Connor); +Cc: dpdk-dev, Ferruh Yigit, Jerin Jacob
On Fri, Apr 30, 2021 at 3:04 PM Min Hu (Connor) <humin29@huawei.com> wrote:
>
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> The thread name already set by rte_ctrl_thread_create() API, so remove
> the call of rte_thread_setname() API.
>
> Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
> lib/eventdev/rte_event_eth_rx_adapter.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index ca166a6..d317e89 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -1432,10 +1432,8 @@ rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter)
>
> err = rte_ctrl_thread_create(&rx_adapter->rx_intr_thread, thread_name,
> NULL, rxa_intr_thread, rx_adapter);
> - if (!err) {
> - rte_thread_setname(rx_adapter->rx_intr_thread, thread_name);
> + if (!err)
> return 0;
> - }
>
> RTE_EDEV_LOG_ERR("Failed to create interrupt thread err = %d\n", err);
> error:
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* [dpdk-dev] [PATCH 2/2] eventdev: fix memory leakage when create thread fail
2021-04-30 9:34 [dpdk-dev] [PATCH 0/2] bugfix for lib eventdev Min Hu (Connor)
2021-04-30 9:34 ` [dpdk-dev] [PATCH 1/2] eventdev: remove redundant setting thread name Min Hu (Connor)
@ 2021-04-30 9:34 ` Min Hu (Connor)
2021-05-01 12:38 ` Jerin Jacob
2021-04-30 15:35 ` [dpdk-dev] [EXT] [PATCH 0/2] bugfix for lib eventdev Pavan Nikhilesh Bhagavatula
2 siblings, 1 reply; 7+ messages in thread
From: Min Hu (Connor) @ 2021-04-30 9:34 UTC (permalink / raw)
To: dev; +Cc: ferruh.yigit, jerinj
From: Chengwen Feng <fengchengwen@huawei.com>
This patch fixes the issue that epoll_events memory is not released
after the intr thread created fail.
Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
Cc: stable@dpdk.org
Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
lib/eventdev/rte_event_eth_rx_adapter.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
index d317e89..13dfb28 100644
--- a/lib/eventdev/rte_event_eth_rx_adapter.c
+++ b/lib/eventdev/rte_event_eth_rx_adapter.c
@@ -1436,6 +1436,7 @@ rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter)
return 0;
RTE_EDEV_LOG_ERR("Failed to create interrupt thread err = %d\n", err);
+ rte_free(rx_adapter->epoll_events);
error:
rte_ring_free(rx_adapter->intr_ring);
rx_adapter->intr_ring = NULL;
--
2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] eventdev: fix memory leakage when create thread fail
2021-04-30 9:34 ` [dpdk-dev] [PATCH 2/2] eventdev: fix memory leakage when create thread fail Min Hu (Connor)
@ 2021-05-01 12:38 ` Jerin Jacob
2021-05-01 14:41 ` Jerin Jacob
0 siblings, 1 reply; 7+ messages in thread
From: Jerin Jacob @ 2021-05-01 12:38 UTC (permalink / raw)
To: Min Hu (Connor), Jayatheerthan, Jay; +Cc: dpdk-dev, Ferruh Yigit, Jerin Jacob
On Fri, Apr 30, 2021 at 3:04 PM Min Hu (Connor) <humin29@huawei.com> wrote:
>
> From: Chengwen Feng <fengchengwen@huawei.com>
>
> This patch fixes the issue that epoll_events memory is not released
> after the intr thread created fail.
>
> Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
> Cc: stable@dpdk.org
>
> Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
Reviewed-by: Jerin Jacob <jerinj@marvell.com>
> ---
> lib/eventdev/rte_event_eth_rx_adapter.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> index d317e89..13dfb28 100644
> --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> @@ -1436,6 +1436,7 @@ rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter)
> return 0;
>
> RTE_EDEV_LOG_ERR("Failed to create interrupt thread err = %d\n", err);
> + rte_free(rx_adapter->epoll_events);
> error:
> rte_ring_free(rx_adapter->intr_ring);
> rx_adapter->intr_ring = NULL;
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: [dpdk-dev] [PATCH 2/2] eventdev: fix memory leakage when create thread fail
2021-05-01 12:38 ` Jerin Jacob
@ 2021-05-01 14:41 ` Jerin Jacob
0 siblings, 0 replies; 7+ messages in thread
From: Jerin Jacob @ 2021-05-01 14:41 UTC (permalink / raw)
To: Min Hu (Connor), Jayatheerthan, Jay; +Cc: dpdk-dev, Ferruh Yigit, Jerin Jacob
On Sat, May 1, 2021 at 6:08 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Fri, Apr 30, 2021 at 3:04 PM Min Hu (Connor) <humin29@huawei.com> wrote:
> >
> > From: Chengwen Feng <fengchengwen@huawei.com>
> >
> > This patch fixes the issue that epoll_events memory is not released
> > after the intr thread created fail.
> >
> > Fixes: 3810ae435783 ("eventdev: add interrupt driven queues to Rx adapter")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> > Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
>
> Reviewed-by: Jerin Jacob <jerinj@marvell.com>
Series applied to dpdk-next-eventdev/for-main. Thanks.
>
>
> > ---
> > lib/eventdev/rte_event_eth_rx_adapter.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c
> > index d317e89..13dfb28 100644
> > --- a/lib/eventdev/rte_event_eth_rx_adapter.c
> > +++ b/lib/eventdev/rte_event_eth_rx_adapter.c
> > @@ -1436,6 +1436,7 @@ rxa_create_intr_thread(struct rte_event_eth_rx_adapter *rx_adapter)
> > return 0;
> >
> > RTE_EDEV_LOG_ERR("Failed to create interrupt thread err = %d\n", err);
> > + rte_free(rx_adapter->epoll_events);
> > error:
> > rte_ring_free(rx_adapter->intr_ring);
> > rx_adapter->intr_ring = NULL;
> > --
> > 2.7.4
> >
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [dpdk-dev] [EXT] [PATCH 0/2] bugfix for lib eventdev
2021-04-30 9:34 [dpdk-dev] [PATCH 0/2] bugfix for lib eventdev Min Hu (Connor)
2021-04-30 9:34 ` [dpdk-dev] [PATCH 1/2] eventdev: remove redundant setting thread name Min Hu (Connor)
2021-04-30 9:34 ` [dpdk-dev] [PATCH 2/2] eventdev: fix memory leakage when create thread fail Min Hu (Connor)
@ 2021-04-30 15:35 ` Pavan Nikhilesh Bhagavatula
2 siblings, 0 replies; 7+ messages in thread
From: Pavan Nikhilesh Bhagavatula @ 2021-04-30 15:35 UTC (permalink / raw)
To: Min Hu (Connor), dev, jay.jayatheerthan
Cc: ferruh.yigit, Jerin Jacob Kollanukkaran
+Cc: jay.jayatheerthan@intel.com>
>This patch set contains two bugfixes for lib eventdev.
>
>Chengwen Feng (2):
> eventdev: remove redundant setting thread name
> eventdev: fix memory leakage when create thread fail
>
> lib/eventdev/rte_event_eth_rx_adapter.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
>--
>2.7.4
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-05-01 14:42 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-30 9:34 [dpdk-dev] [PATCH 0/2] bugfix for lib eventdev Min Hu (Connor)
2021-04-30 9:34 ` [dpdk-dev] [PATCH 1/2] eventdev: remove redundant setting thread name Min Hu (Connor)
2021-05-01 12:38 ` Jerin Jacob
2021-04-30 9:34 ` [dpdk-dev] [PATCH 2/2] eventdev: fix memory leakage when create thread fail Min Hu (Connor)
2021-05-01 12:38 ` Jerin Jacob
2021-05-01 14:41 ` Jerin Jacob
2021-04-30 15:35 ` [dpdk-dev] [EXT] [PATCH 0/2] bugfix for lib eventdev Pavan Nikhilesh Bhagavatula
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).