From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 3AC3D2B8C for ; Thu, 9 Mar 2017 17:05:52 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Mar 2017 08:05:51 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.36,136,1486454400"; d="scan'208";a="1120515767" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.255.86.60]) ([10.255.86.60]) by fmsmga001.fm.intel.com with ESMTP; 09 Mar 2017 08:05:49 -0800 To: "Wiles, Keith" References: <1488904298-31395-3-git-send-email-pascal.mazon@6wind.com> <1c44b4be-943a-2911-f91b-f61ebf0eb258@intel.com> Cc: Pascal Mazon , "dev@dpdk.org" From: Ferruh Yigit Message-ID: <161c8ab9-2b3f-121d-bf0c-9be7fae531b9@intel.com> Date: Thu, 9 Mar 2017 16:05:47 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/6] net/tap: add speed capabilities X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Mar 2017 16:05:53 -0000 On 3/9/2017 2:36 PM, Wiles, Keith wrote: > >> On Mar 9, 2017, at 8:18 AM, Yigit, Ferruh wrote: >> >> On 3/7/2017 4:31 PM, Pascal Mazon wrote: >>> Tap PMD is flexible, it supports any speed. >>> >>> Signed-off-by: Pascal Mazon >>> --- >>> doc/guides/nics/features/tap.ini | 1 + >>> drivers/net/tap/rte_eth_tap.c | 35 +++++++++++++++++++++++++++++++++++ >>> 2 files changed, 36 insertions(+) >>> >>> diff --git a/doc/guides/nics/features/tap.ini b/doc/guides/nics/features/tap.ini >>> index d9b47a003654..dad5a0561087 100644 >>> --- a/doc/guides/nics/features/tap.ini >>> +++ b/doc/guides/nics/features/tap.ini >>> @@ -9,6 +9,7 @@ Jumbo frame = Y >>> Promiscuous mode = Y >>> Allmulticast mode = Y >>> Basic stats = Y >>> +Speed capabilities = Y >>> Unicast MAC filter = Y >>> Other kdrv = Y >>> ARMv7 = Y >>> diff --git a/drivers/net/tap/rte_eth_tap.c b/drivers/net/tap/rte_eth_tap.c >>> index 1e46ee36efa2..ef525a3f0826 100644 >>> --- a/drivers/net/tap/rte_eth_tap.c >>> +++ b/drivers/net/tap/rte_eth_tap.c >>> @@ -351,6 +351,40 @@ tap_dev_configure(struct rte_eth_dev *dev __rte_unused) >>> return 0; >>> } >>> >>> +static uint32_t >>> +tap_dev_speed_capa(void) >>> +{ >>> + uint32_t speed = pmd_link.link_speed; >> >> link_speed is already hardcoded into PMD, so there is nothing to detect >> here. Would it be different if PMD directly return pmd_link.link_speed? > > The link speed is passed into the PMD via the command line, which means it can change per run. Right, I missed that.