From: Thomas Monjalon <thomas@monjalon.net>
To: Ali Alnubani <alialnu@mellanox.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH] test/test_external_mem: fix loop initialization
Date: Tue, 23 Oct 2018 11:06:14 +0200 [thread overview]
Message-ID: <1620738.05UcecG66J@xps> (raw)
In-Reply-To: <20181023073535.16441-1-alialnu@mellanox.com>
23/10/2018 09:35, Ali Alnubani:
> Loop initial declarations are only allowed in C99 mode,
> which causes a compilation failure on non C99 compliant systems:
>
> test/test/test_external_mem.c: In function ‘test_external_mem’:
> test/test/test_external_mem.c:375:2: error: ‘for’
> loop initial declarations are only allowed in C99 mode
> for (int i = 0; i < n_pages; i++) {
> ^
>
> Reproduces on RHEL 7.4 with GCC 4.8.5 20150623 (Red Hat 4.8.5-16).
>
> Fixes: b270daa43b3d ("test: support external memory")
> Cc: anatoly.burakov@intel.com
>
> Signed-off-by: Ali Alnubani <alialnu@mellanox.com>
There was already a patch from Dan Gora:
http://patches.dpdk.org/patch/46921/
prev parent reply other threads:[~2018-10-23 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-23 7:35 Ali Alnubani
2018-10-23 9:06 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1620738.05UcecG66J@xps \
--to=thomas@monjalon.net \
--cc=alialnu@mellanox.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).