From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id F421EA0C47; Thu, 13 May 2021 08:19:55 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3EBEC410FE; Thu, 13 May 2021 08:19:51 +0200 (CEST) Received: from szxga07-in.huawei.com (szxga07-in.huawei.com [45.249.212.35]) by mails.dpdk.org (Postfix) with ESMTP id 84E414003F for ; Thu, 13 May 2021 08:19:48 +0200 (CEST) Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga07-in.huawei.com (SkyGuard) with ESMTP id 4FghJd19dVzBts8; Thu, 13 May 2021 14:17:05 +0800 (CST) Received: from localhost.localdomain (10.67.165.24) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.498.0; Thu, 13 May 2021 14:19:43 +0800 From: Chengwen Feng To: , CC: , , , , , , , , Date: Thu, 13 May 2021 14:16:39 +0800 Message-ID: <1620886600-40388-2-git-send-email-fengchengwen@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1620886600-40388-1-git-send-email-fengchengwen@huawei.com> References: <1620808126-18876-1-git-send-email-fengchengwen@huawei.com> <1620886600-40388-1-git-send-email-fengchengwen@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Subject: [dpdk-dev] [PATCH v3 1/2] config/arm: select most suitable -march for kunpeng soc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Currently, the soc_kunpeng930 declares '-march=armv8.2-a+crypto+sve', but some compiler doesn't recognize the march because it doesn't support sve. To solve this bug we use the following scheme: 1. Define 'march_base' tuple which defines support march, it should arrange from lower to higher. e.g. 'march_base' : ['-march=armv8-a', '-march=armv8.2-a'] 2. Define 'march_feature' tuple which defines support feature. e.g. 'march_feature' : ['crypto', 'sve'] 3. Select the most suitable march+feature combination based on 'march_base' and 'march_feature' tuples. 4. Use the selected march+feature combination as the default machine_args. Fixes: 7cf32a22b240 ("config/arm: add Hisilicon kunpeng") Signed-off-by: Chengwen Feng --- config/arm/meson.build | 28 +++++++++++++++++++++++++--- 1 file changed, 25 insertions(+), 3 deletions(-) diff --git a/config/arm/meson.build b/config/arm/meson.build index 3f34ec9..7d1a823 100644 --- a/config/arm/meson.build +++ b/config/arm/meson.build @@ -149,7 +149,9 @@ implementer_hisilicon = { ], 'part_number_config': { '0xd01': { - 'machine_args': ['-march=armv8.2-a+crypto', '-mtune=tsv110'], + 'march_base' : ['-march=armv8-a', '-march=armv8.2-a'], + 'march_feature' : ['crypto'], + 'machine_args': ['-mtune=tsv110'], 'flags': [ ['RTE_MACHINE', '"Kunpeng 920"'], ['RTE_ARM_FEATURE_ATOMICS', true], @@ -158,7 +160,9 @@ implementer_hisilicon = { ] }, '0xd02': { - 'machine_args': ['-march=armv8.2-a+crypto+sve'], + 'march_base' : ['-march=armv8-a', '-march=armv8.2-a'], + 'march_feature' : ['crypto', 'sve'], + 'machine_args': [], 'flags': [ ['RTE_MACHINE', '"Kunpeng 930"'], ['RTE_ARM_FEATURE_ATOMICS', true], @@ -449,8 +453,26 @@ else # add/overwrite flags in the proper order dpdk_flags = flags_common + implementer_config['flags'] + part_number_config.get('flags', []) + soc_flags + # select the most suitable march+feature combination + machine_march = [] + if part_number_config.has_key('march_base') + foreach arch: part_number_config['march_base'] + if cc.has_argument(arch) + machine_march = arch # Set the higher supported arch as possible + endif + endforeach + endif + if part_number_config.has_key('march_feature') + foreach feature: part_number_config['march_feature'] + tmp_machine_march = machine_march + '+' + feature + if cc.has_argument(tmp_machine_march) + machine_march = tmp_machine_march # Set the more supported feature as possible + endif + endforeach + endif + # apply supported machine args - machine_args = [] # Clear previous machine args + machine_args = machine_march foreach flag: part_number_config['machine_args'] if cc.has_argument(flag) machine_args += flag -- 2.8.1