DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Ilya Maximets <i.maximets@ovn.org>
Cc: i.maximets@ovn.org, dev@dpdk.org, stable@dpdk.org,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	Haiyue Wang <haiyue.wang@intel.com>,
	John Daley <johndale@cisco.com>,
	Guoyang Zhou <zhouguoyang@huawei.com>,
	"Min Hu (Connor)" <humin29@huawei.com>,
	Beilei Xing <beilei.xing@intel.com>,
	Jingjing Wu <jingjing.wu@intel.com>,
	Qi Zhang <qi.z.zhang@intel.com>, Rosen Xu <rosen.xu@intel.com>,
	Matan Azrad <matan@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Liron Himi <lironh@marvell.com>,
	Jiawen Wu <jiawenwu@trustnetic.com>, Ori Kam <orika@nvidia.com>,
	ferruh.yigit@amd.com, andrew.rybchenko@oktetlabs.ru,
	david.marchand@redhat.com, olivier.matz@6wind.com
Subject: Re: [PATCH] doc: fix support table for ETH and VLAN flow items
Date: Thu, 13 Oct 2022 14:18:03 +0200	[thread overview]
Message-ID: <16216253.dW097sEU6C@thomas> (raw)
In-Reply-To: <bd3473d5-0864-f43b-de65-5be00483b5a0@ovn.org>

13/10/2022 13:01, Ilya Maximets:
> On 10/12/22 17:30, Thomas Monjalon wrote:
> > 07/10/2022 13:55, Ilya Maximets:
> >> On 10/7/22 13:50, Ilya Maximets wrote:
> >>> On 9/12/22 12:09, Thomas Monjalon wrote:
> >>>> 16/03/2022 13:01, Ilya Maximets:
> >>>>> 'has_vlan' attribute is only supported by sfc, mlx5 and cnxk.
> >>>>> Other drivers doesn't support it.  Most of them (like i40e) just
> >>>>> ignore it silently.  Some drivers (like mlx4) never had a full
> >>>>> support of the eth item even before introduction of 'has_vlan'
> >>>>> (mlx4 allows to match on the destination MAC only).
> >>>>>
> >>>>> Same for the 'has_more_vlan' flag of the vlan item.
> >>>>>
> >>>>> Changing the support level to 'partial' for all such drivers.
> >>>>> This doesn't solve the issue, but at least marks the problematic
> >>>>> drivers.
> >>>>
> >>>> You changed "eth" and "vlan" from "Y" to "P".
> >>>> The field "has_vlan" is part of "rte_flow_item_eth",
> >>>> and "has_more_vlan" is part of "rte_flow_item_vlan",
> >>>> so I agree we need to change both items to "partial support".
> >>>> It looks to be a good change, just needs to more explicit,
> >>>> adding this kind of explanation about the fields.
> >>>
> >>> I can add this to the commit message.  Should I also add
> >>> some note alongside the table in that documentation page?
> > 
> > I'm afraid it can be long and complex to add notes in the page
> > about what is missing to get complete support for each feature/PMD.
> > I think you can just re-spin with a clear explanation in the commit,
> > so PMD maintainers can refer to it.
> 
> OK.  v2 sent here:
>   https://patches.dpdk.org/project/dpdk/patch/20221013104849.2677995-1-i.maximets@ovn.org/

Thank you, I'm currently working on the rte_flow_items to use structs from librte_net.



      reply	other threads:[~2022-10-13 12:18 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 12:01 Ilya Maximets
2022-04-20 17:51 ` Ferruh Yigit
2022-04-26  8:55   ` Asaf Penso
2022-04-26 10:47     ` Ferruh Yigit
2022-04-27 11:02       ` Asaf Penso
2022-09-12 10:09 ` Thomas Monjalon
2022-09-12 11:08   ` Ori Kam
2022-10-07 11:50   ` Ilya Maximets
2022-10-07 11:55     ` Ilya Maximets
2022-10-12 15:30       ` Thomas Monjalon
2022-10-13 11:01         ` Ilya Maximets
2022-10-13 12:18           ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16216253.dW097sEU6C@thomas \
    --to=thomas@monjalon.net \
    --cc=ajit.khaparde@broadcom.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=beilei.xing@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@amd.com \
    --cc=haiyue.wang@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=humin29@huawei.com \
    --cc=i.maximets@ovn.org \
    --cc=jiawenwu@trustnetic.com \
    --cc=jingjing.wu@intel.com \
    --cc=johndale@cisco.com \
    --cc=lironh@marvell.com \
    --cc=matan@nvidia.com \
    --cc=olivier.matz@6wind.com \
    --cc=orika@nvidia.com \
    --cc=qi.z.zhang@intel.com \
    --cc=rahul.lakkireddy@chelsio.com \
    --cc=rosen.xu@intel.com \
    --cc=stable@dpdk.org \
    --cc=viacheslavo@nvidia.com \
    --cc=zhouguoyang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).