From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DD844A04DC;
	Tue, 20 Oct 2020 16:22:58 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id A9A2DBC7A;
	Tue, 20 Oct 2020 16:22:57 +0200 (CEST)
Received: from new4-smtp.messagingengine.com (new4-smtp.messagingengine.com
 [66.111.4.230]) by dpdk.org (Postfix) with ESMTP id 4FE8BBC4A;
 Tue, 20 Oct 2020 16:22:55 +0200 (CEST)
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailnew.nyi.internal (Postfix) with ESMTP id F2DAD58035D;
 Tue, 20 Oct 2020 10:22:53 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Tue, 20 Oct 2020 10:22:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 from:to:cc:subject:date:message-id:in-reply-to:references
 :mime-version:content-transfer-encoding:content-type; s=fm2; bh=
 sREDKxuBk2voXtQbjxZnSD56HMaP22rIU/2Gv8umjOo=; b=fppfTqX+gXnY+kvh
 Zsm/eMsYuSsZNBmuG7TzHc7oHbD5Ig/7Q1StUSCND0IiFMDd4vzKp/v1C/GGt4mo
 Csur3PEfb9U6migQOt9jCpDYKldWkbpbuqvnV3wnia9RUd2vi75LJJGuA6tZI2hS
 iYZ6p3YuyBErThp9Tj6zAhxlUnHt1xH1E1aEXCk0IKzN7n1dkZhQPK9z6xjMqbnr
 zUHVcrPI3EzZhRL6LCfleCmjfKZycmiYLt5sY2HSc2/I1rrck1X/cR9inW2VZl7x
 nZeHNWjd+KwBUgBYXwN3WWuyNEvqQ/WX9n48+Y266Ghyby7a6EM97ja7YszFlDwB
 Zzyhuw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm1; bh=sREDKxuBk2voXtQbjxZnSD56HMaP22rIU/2Gv8umj
 Oo=; b=f3up6PNqk8yBr312K9+OU7LluE4AOceYXbeXi+97qC6O6KOK8ap6wBzwt
 vrExWGh4ghIegzFKh7EGoVK3GooN+CPezWZXmBGgMNL7V1uQX06ykYGRg4yGQ/jj
 IHAr1iJxjqs8247tdH8mi65dAZJfkfULgqrvTkKy8Igp0HdjTNu4HI/MYSDPU7bU
 K3kdnSy54Qv6jarcYsc89VOlJZ9SVn3+ksOTCk3ApR8OvxknWRR5DP++V4Zgl+YC
 NOWdDi+C5KlAZZdi3ssZaZi/cXna1AQae/pilViA8x/ZngC3z790gSoCJIapqdP4
 DbNsKyUAcPKlF4MfQTV7+MSfCpwOQ==
X-ME-Sender: <xms:vPKOX33zTalr62pDvn5qlS8fKfV1xMpYrOv1FiHbNO_f-qlybJ_ISA>
 <xme:vPKOX2EWJUTobeo07j7iN145x3zcO7rMQN_q9R9fm-08QVue5OuQEb98ryGuTfBe_
 XjDSA7v6-K3kDKZUw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrjeefgdejgecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhmrghs
 ucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenucggtf
 frrghtthgvrhhnpedugefgvdefudfftdefgeelgffhueekgfffhfeujedtteeutdejueei
 iedvffegheenucfkphepjeejrddufeegrddvtdefrddukeegnecuvehluhhsthgvrhfuih
 iivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhho
 nhdrnhgvth
X-ME-Proxy: <xmx:vPKOX34FsgwvdoKAXyfHJeGzCU7P8w4tq2iKePbSkwQWvk3o3iAW5Q>
 <xmx:vPKOX832xvGrznTHBvEfbrRPVWN4Y0mf-uQ2_4SZcBLIKNh3j8MkaA>
 <xmx:vPKOX6EHszqiVGAfK7KF1WHkWTiQyp7QOSInozhW1YbzHcksXRNmfw>
 <xmx:vfKOXxcIb6lgO2SEXEYTuJu6JEYb01iw0BswKRMTRTofpXnrUYQMDA>
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id EDBDF3280060;
 Tue, 20 Oct 2020 10:22:50 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: "techboard@dpdk.org" <techboard@dpdk.org>
Cc: dev@dpdk.org, "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>,
 Michel Machado <michel@digirati.com.br>, Kevin Traynor <ktraynor@redhat.com>,
 Ruifeng Wang <Ruifeng.Wang@arm.com>,
 Bruce Richardson <bruce.richardson@intel.com>, Cody Doucette <doucette@bu.edu>,
 Andre Nathan <andre@digirati.com.br>, Qiaobin Fu <mengxiang0811@gmail.com>,
 "dev@dpdk.org" <dev@dpdk.org>, nd <nd@arm.com>,
 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>,
 David Marchand <david.marchand@redhat.com>, jerinj@marvell.com,
 stephen@networkplumber.org
Date: Tue, 20 Oct 2020 16:22:49 +0200
Message-ID: <1622221.TErq07bq3z@thomas>
In-Reply-To: <CAJFAV8w0oDiNW_vLQMReh8q+v+9p=h+W5HzzGKr0q73k83bdsg@mail.gmail.com>
References: <20200907081518.46350-1-ruifeng.wang@arm.com>
 <DBAPR08MB581430BDB3D55AF6F611C0B498020@DBAPR08MB5814.eurprd08.prod.outlook.com>
 <CAJFAV8w0oDiNW_vLQMReh8q+v+9p=h+W5HzzGKr0q73k83bdsg@mail.gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

19/10/2020 16:53, David Marchand:
> On Fri, Oct 16, 2020 at 12:54 AM Honnappa Nagarahalli
> <Honnappa.Nagarahalli@arm.com> wrote:
> > > > IMO, this is not a performance critical path and it is not a difficult solution to
> > > store these values in the application. My suggestion is to skip adding the API
> > > and store the values in the application.
> > > > Vladimir, what's your opinion?
> > >
> > > Agree. Global vars or part of a global configuration could be used here.
> > Thank you. I think we are fine to go ahead with merging this patch.
> 
> I saw Honnappa and Kevin acks, are other techboard members aware and
> okay with this change?

This is an API change for better maintenance.
I'm not sure the benefit is big enough,
but the cost for the applications is said to be workable.
Better to do it now than later, so

Acked-by: Thomas Monjalon <thomas@monjalon.net>
(at the condition it is added in release notes)

What others think?