From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53]) by dpdk.org (Postfix) with ESMTP id 6D0FA2BD6 for ; Tue, 22 Mar 2016 20:40:46 +0100 (CET) Received: by mail-wm0-f53.google.com with SMTP id l68so206838997wml.0 for ; Tue, 22 Mar 2016 12:40:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=oUtN3B+SCWsQdOo9+Nn+vb+z/nXzgg7ajyUD0qih+fI=; b=0dp91DY4H208vW6/XKWfoH9q8/wnD31nyvwLCyNiH+VQLPJ/h3o9BFCxvpBQxJZUWc vZHE35iRQsVC7GZvLIlec0lfWFlMblsPIG9IPFROSoZns3teVKAms8odDs9YBWI6kxJK f6KVbj/mDTGvgfl3fS/Ng2d2yWrhqk0XxxEHUPDSAe6HeyfZXjp58jgVIjY1t0n+HYqn 6JXk+aeL6TEj4GC4SIaw1Dvq9iSeSnNAUcAoTiI/Ht7PK6w2Ey4pKasR9gfScLsQ4ICj NImH9BhuRAOAMzDjfIYcwrpGr59FOZ/aymb7vKXr6j6pOXRKIAj2/pfTm0F2jUctz1uq 64eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding; bh=oUtN3B+SCWsQdOo9+Nn+vb+z/nXzgg7ajyUD0qih+fI=; b=SP3cIwYBY6X1zDhcnPXv2MN+zY84p0rd84TNM5m1nNyRjVjiupxCSreCGAM2ePdBqt /6s7cKqQZ3EqAcVtmLP0PVPrMBAYcb95rq0qbP+k/7plRnqeFgR1CfGVkngxH3hotRJe ZUwqtE/vOfoRuIBnrhZ8WId0Cw40y23hwBWc5tVIHTI4Y926Y+gXX9TEEL78IqlgHxWc 7ijzKtYII9wLfZFUuTfFKVausnBxX/kcKPwpRSEuABqUv7FHl/VIweHGoPo/u+q1ySCN bNyPjHtaMKYB00v8lVhLTzDTreMHzACpHCYLEw6svgVXIESm+ubtyIJWVtOu8+4ANy9+ 55zg== X-Gm-Message-State: AD7BkJJ9MuqsRe69we9pE7m2iRKRwp5E2UkSVx5Jz+II2OTIzhO6Vmvad0GGKzavEyvpYYd/ X-Received: by 10.194.103.227 with SMTP id fz3mr34198180wjb.43.1458675646210; Tue, 22 Mar 2016 12:40:46 -0700 (PDT) Received: from xps13.localnet (91.111.75.86.rev.sfr.net. [86.75.111.91]) by smtp.gmail.com with ESMTPSA id r8sm31674710wjz.34.2016.03.22.12.40.45 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 22 Mar 2016 12:40:45 -0700 (PDT) From: Thomas Monjalon To: Panu Matilainen Cc: dev@dpdk.org, Ferruh Yigit Date: Tue, 22 Mar 2016 20:39:05 +0100 Message-ID: <1622870.FhASFun3h6@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <56EFDF88.2040309@intel.com> References: <233492f10ac71dd9f6902eaa4bca425febc5d2c0.1458560038.git.pmatilai@redhat.com> <27d49a881875edbfdacbf8f621d38c3927a95881.1458560038.git.pmatilai@redhat.com> <56EFDF88.2040309@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH 2/2] mk: fix two more missing libm dependencies X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Mar 2016 19:40:46 -0000 2016-03-21 11:48, Ferruh Yigit: > On 3/21/2016 11:33 AM, Panu Matilainen wrote: > > Commit e86a699cf6b1 missed two further libm dependencies: ceil() used by > > librte_meter is typically inlined so the missing dependency does not > > actually cause failures, and librte_pmd_nfp is not built by default > > so its easy to miss. > > > > This causes duplicates in LDLIBS in many configurations so its vital > > they are removed before passing to linker. > > > > Fixes: e86a699cf6b1 ("mk: fix shared library dependencies on libm and librt") > > > > Reported-by: Ferruh Yigit > > Signed-off-by: Panu Matilainen > > Tested-by: Ferruh Yigit Applied, thanks