From: "Min Hu (Connor)" <humin29@huawei.com>
To: <dev@dpdk.org>
Cc: <ferruh.yigit@intel.com>
Subject: [dpdk-dev] [PATCH 4/6] net/hns3: fix VLAN strip log
Date: Sun, 13 Jun 2021 10:31:54 +0800 [thread overview]
Message-ID: <1623551516-49635-5-git-send-email-humin29@huawei.com> (raw)
In-Reply-To: <1623551516-49635-1-git-send-email-humin29@huawei.com>
From: Chengchang Tang <tangchengchang@huawei.com>
When the current VLAN stripping is set, the log print always prompts
that the enabling fails, bug if may actually be the disabling failure.
Fixes: 411d23b9eafb ("net/hns3: support VLAN")
Cc: stable@dpdk.org
Signed-off-by: Chengchang Tang <tangchengchang@huawei.com>
Signed-off-by: Min Hu (Connor) <humin29@huawei.com>
---
drivers/net/hns3/hns3_ethdev.c | 3 ++-
drivers/net/hns3/hns3_ethdev_vf.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/net/hns3/hns3_ethdev.c b/drivers/net/hns3/hns3_ethdev.c
index 7b0e938..db96fbc 100644
--- a/drivers/net/hns3/hns3_ethdev.c
+++ b/drivers/net/hns3/hns3_ethdev.c
@@ -640,7 +640,8 @@ hns3_en_hw_strip_rxvtag(struct hns3_adapter *hns, bool enable)
ret = hns3_set_vlan_rx_offload_cfg(hns, &rxvlan_cfg);
if (ret) {
- hns3_err(hw, "enable strip rx vtag failed, ret =%d", ret);
+ hns3_err(hw, "%s strip rx vtag failed, ret = %d.",
+ enable ? "enable" : "disable", ret);
return ret;
}
diff --git a/drivers/net/hns3/hns3_ethdev_vf.c b/drivers/net/hns3/hns3_ethdev_vf.c
index e4908de..e0a0797 100644
--- a/drivers/net/hns3/hns3_ethdev_vf.c
+++ b/drivers/net/hns3/hns3_ethdev_vf.c
@@ -1606,7 +1606,8 @@ hns3vf_en_hw_strip_rxvtag(struct hns3_hw *hw, bool enable)
ret = hns3_send_mbx_msg(hw, HNS3_MBX_SET_VLAN, HNS3_MBX_VLAN_RX_OFF_CFG,
&msg_data, sizeof(msg_data), false, NULL, 0);
if (ret)
- hns3_err(hw, "vf enable strip failed, ret =%d", ret);
+ hns3_err(hw, "vf %s strip failed, ret = %d.",
+ enable ? "enable" : "disable", ret);
return ret;
}
--
2.7.4
next prev parent reply other threads:[~2021-06-13 2:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-13 2:31 [dpdk-dev] [PATCH 0/6] bugfixes for hns3 PMD Min Hu (Connor)
2021-06-13 2:31 ` [dpdk-dev] [PATCH 1/6] net/hns3: modify max reset fail retry count Min Hu (Connor)
2021-06-14 14:36 ` Andrew Rybchenko
2021-06-13 2:31 ` [dpdk-dev] [PATCH 2/6] net/hns3: fix delay time for waiting to stop rxtx Min Hu (Connor)
2021-06-13 2:31 ` [dpdk-dev] [PATCH 3/6] net/hns3: fix incorrect fake queue rollback Min Hu (Connor)
2021-06-13 2:31 ` Min Hu (Connor) [this message]
2021-06-13 2:31 ` [dpdk-dev] [PATCH 5/6] net/hns3: fix config max queues to zero when fails Min Hu (Connor)
2021-06-13 2:31 ` [dpdk-dev] [PATCH 6/6] net/hns3: delete redundant blank lines Min Hu (Connor)
2021-06-14 14:43 ` [dpdk-dev] [PATCH 0/6] bugfixes for hns3 PMD Andrew Rybchenko
2021-06-15 0:47 ` Min Hu (Connor)
2021-06-17 14:56 ` Andrew Rybchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1623551516-49635-5-git-send-email-humin29@huawei.com \
--to=humin29@huawei.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).