DPDK patches and discussions
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Raslan Darawsheh <rasland@mellanox.com>,
	Moshe Levi <moshele@mellanox.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	Adrian Chiris <adrianc@mellanox.com>,
	Matan Azrad <matan@mellanox.com>,
	Shahaf Shuler <shahafs@mellanox.com>,
	Slava Ovsiienko <viacheslavo@mellanox.com>,
	John McNamara <john.mcnamara@intel.com>,
	Marko Kovacevic <marko.kovacevic@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: add required Linux capabilities in mlx5	guide
Date: Tue, 19 May 2020 11:05:28 +0200	[thread overview]
Message-ID: <1625119.vEMTNlK7mp@thomas> (raw)
In-Reply-To: <AM6PR05MB5425AFDBDAC1B15D1330F0B0D0BC0@AM6PR05MB5425.eurprd05.prod.outlook.com>

14/05/2020 19:29, Moshe Levi:
> > From: Thomas Monjalon
> > > +``cap_net_admin``
> > > +   For MTU and link state modifications
> 
> It more than that like change mac address . maybe better to write for interface configuration 
> You can see the full list in [1] look for CAP_NET_ADMIN
> [1] - http://man7.org/linux/man-pages/man7/capabilities.7.html

Changed to "For device configuration." while merging in master.


> > > +``cap_net_raw``
> > > +   For raw ethernet queue allocation through kernel driver.
> Maybe can you add a note that for containers the net_raw is enabled by default see [1] and you don't need to specify it. 
>  [1] - https://docs.docker.com/engine/reference/run/#runtime-privilege-and-linux-capabilities

It would require a separate patch please.



      reply	other threads:[~2020-05-19  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-02 23:08 Thomas Monjalon
2020-05-14  8:23 ` Raslan Darawsheh
2020-05-14 17:29   ` Moshe Levi
2020-05-19  9:05     ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1625119.vEMTNlK7mp@thomas \
    --to=thomas@monjalon.net \
    --cc=adrianc@mellanox.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=marko.kovacevic@intel.com \
    --cc=matan@mellanox.com \
    --cc=moshele@mellanox.com \
    --cc=rasland@mellanox.com \
    --cc=shahafs@mellanox.com \
    --cc=viacheslavo@mellanox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).