From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <thomas@monjalon.net>
Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com
 [66.111.4.28]) by dpdk.org (Postfix) with ESMTP id 05CF81C00
 for <dev@dpdk.org>; Wed, 10 May 2017 15:51:23 +0200 (CEST)
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.nyi.internal (Postfix) with ESMTP id 704EC20C5B;
 Wed, 10 May 2017 09:51:23 -0400 (EDT)
Received: from frontend1 ([10.202.2.160])
 by compute1.internal (MEProxy); Wed, 10 May 2017 09:51:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h=
 cc:content-transfer-encoding:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-sender
 :x-me-sender:x-sasl-enc:x-sasl-enc; s=mesmtp; bh=60hQ/B+5u9GPrgf
 JVFRWz++21letGw4dC7iHfgXH0mM=; b=MO9JTPNdg2XcIeoL+33AzqKWiTaW3H8
 9v2+eepnfBwaDkneIdlV/xaLzbXDxt2bXiGZxn+uNJs4b8NUqnCeokrd1iAP5JWU
 qKL7+i+loe59sWzZ7BPodO+X6xuOmLGY1VABEnktMwUcBh+3OXftXn7FePNeVg0p
 QPE5AGvPwzuo=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=
 fm1; bh=60hQ/B+5u9GPrgfJVFRWz++21letGw4dC7iHfgXH0mM=; b=I3sGc4zH
 CHELxCqX7Q4e09j45h0L2OTZCogRs7JYdgRX2Xh6ZezHZS5PXjZFmhp3oQn8a/qk
 up59vUa9/h2B10qs6ulGntpCN1bOj8PomQSFBCH58We/DoLFCIBqdXw9VSoOmlaN
 znxF8O6hkbMJxvXjhJR+3hpwaedo+7jk8cC7fVoi4ttyvFVuuNqG3z9ejVxuvnA9
 aT67NiVvGdAciXCNuTi34o2y4r3fV8VXDWmPjUP0VzqJBiPxBYp634G2AxAs8AFU
 HCZknXliWg57MGxsFNi6bxU76op5IHQGCdhJ5qh/CGGMzaq96qjFZDC/uV4Nhvs5
 zDD6m5pz2MUPGA==
X-ME-Sender: <xms:2xoTWWBn5J3vuuLmGXat1WPapR9cErDemZwuRz5U6MCi0eSqlqWbvw>
X-Sasl-enc: k7BelT+eiRVfci5o7r4xLRrKQON6WXPCucQk7/asjQrs 1494424283
Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184])
 by mail.messagingengine.com (Postfix) with ESMTPA id 090707E9D6;
 Wed, 10 May 2017 09:51:23 -0400 (EDT)
From: Thomas Monjalon <thomas@monjalon.net>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dev@dpdk.org, Shepard Siegel <shepard.siegel@atomicrules.com>,
 Ed Czeck <ed.czeck@atomicrules.com>,
 John Miller <john.miller@atomicrules.com>,
 John McNamara <john.mcnamara@intel.com>,
 Harish Patil <harish.patil@cavium.com>,
 Rasesh Mody <rasesh.mody@cavium.com>,
 Rahul Lakkireddy <rahul.lakkireddy@chelsio.com>,
 Hemant Agrawal <hemant.agrawal@nxp.com>,
 Shreyansh Jain <shreyansh.jain@nxp.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Marcin Wojtas <mw@semihalf.com>,
 Michal Krawczyk <mk@semihalf.com>, Guy Tzalik <gtzalik@amazon.com>,
 Evgeny Schemeilin <evgenys@amazon.com>,
 Jing Chen <jing.d.chen@intel.com>, Helin Zhang <helin.zhang@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>,
 Adrien Mazarguil <adrien.mazarguil@6wind.com>,
 Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
 Matej Vido <vido@cesnet.cz>, Pascal Mazon <pascal.mazon@6wind.com>,
 Yuanhan Liu <yuanhan.liu@linux.intel.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Shrikrishna Khare <skhare@vmware.com>
Date: Wed, 10 May 2017 15:51:22 +0200
Message-ID: <16254100.QC6ztoDaX8@xps>
In-Reply-To: <20170510131053.75843-1-ferruh.yigit@intel.com>
References: <20170510131053.75843-1-ferruh.yigit@intel.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Subject: Re: [dpdk-dev] [PATCH] drivers/net: document missing speed
	capabilities feature
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 10 May 2017 13:51:24 -0000

10/05/2017 15:10, Ferruh Yigit:
> --- a/doc/guides/nics/features/bnx2x.ini
> +++ b/doc/guides/nics/features/bnx2x.ini
> @@ -4,6 +4,7 @@
>  ; Refer to default.ini for the full list of available PMD features.
>  ;
>  [Features]
> +Speed capabilities   = Y

We should validate this feature only if the driver advertise the
right speeds for the device.
Most of drivers advertise every possible speeds for the driver
without considering device limitations.