DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] crypto/cnxk: add PCI ID for cn9k
@ 2021-07-09  6:28 Anoob Joseph
  2021-07-09  6:30 ` Akhil Goyal
  2021-07-09 12:09 ` David Marchand
  0 siblings, 2 replies; 3+ messages in thread
From: Anoob Joseph @ 2021-07-09  6:28 UTC (permalink / raw)
  To: Akhil Goyal, Thomas Monjalon, Ali Alnubani, David Marchand
  Cc: Anoob Joseph, Jerin Jacob, Ankur Dwivedi, Tejasree Kondoj, dev

Add PCI ID for crypo_cn9k PMD.

To avoid conflicting PCI ID in crypto_octeontx2 and
crypto_cn9k PMDs, disable crypto_cn9k PMD when built with
octeontx2 config.

The lack of PCI ID is causing debug build to fail for
crypto_cn9k PMD.

Reported-by: Ali Alnubani <alialnu@mellanox.com>
Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---
 config/arm/arm64_octeontx2_linux_gcc | 1 +
 drivers/crypto/cnxk/cn9k_cryptodev.c | 2 ++
 2 files changed, 3 insertions(+)

diff --git a/config/arm/arm64_octeontx2_linux_gcc b/config/arm/arm64_octeontx2_linux_gcc
index 9156ee5..8fbdd38 100644
--- a/config/arm/arm64_octeontx2_linux_gcc
+++ b/config/arm/arm64_octeontx2_linux_gcc
@@ -14,3 +14,4 @@ endian = 'little'
 
 [properties]
 platform = 'octeontx2'
+disable_drivers = 'common/cnxk'
diff --git a/drivers/crypto/cnxk/cn9k_cryptodev.c b/drivers/crypto/cnxk/cn9k_cryptodev.c
index e74e739..71d144f 100644
--- a/drivers/crypto/cnxk/cn9k_cryptodev.c
+++ b/drivers/crypto/cnxk/cn9k_cryptodev.c
@@ -21,6 +21,8 @@ uint8_t cn9k_cryptodev_driver_id;
 
 static struct rte_pci_id pci_id_cpt_table[] = {
 	{
+		RTE_PCI_DEVICE(PCI_VENDOR_ID_CAVIUM,
+			       PCI_DEVID_CN9K_RVU_CPT_VF)
 	},
 	/* sentinel */
 	{
-- 
2.7.4


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/cnxk: add PCI ID for cn9k
  2021-07-09  6:28 [dpdk-dev] [PATCH] crypto/cnxk: add PCI ID for cn9k Anoob Joseph
@ 2021-07-09  6:30 ` Akhil Goyal
  2021-07-09 12:09 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: Akhil Goyal @ 2021-07-09  6:30 UTC (permalink / raw)
  To: Anoob Joseph, Thomas Monjalon, Ali Alnubani, David Marchand
  Cc: Anoob Joseph, Jerin Jacob Kollanukkaran, Ankur Dwivedi,
	Tejasree Kondoj, dev

> Add PCI ID for crypo_cn9k PMD.
> 
> To avoid conflicting PCI ID in crypto_octeontx2 and
> crypto_cn9k PMDs, disable crypto_cn9k PMD when built with
> octeontx2 config.
> 
> The lack of PCI ID is causing debug build to fail for
> crypto_cn9k PMD.
> 
> Reported-by: Ali Alnubani <alialnu@mellanox.com>
> Suggested-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> ---
Thomas,

Can you pick this directly on main?

Regards,
Akhil

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [dpdk-dev] [PATCH] crypto/cnxk: add PCI ID for cn9k
  2021-07-09  6:28 [dpdk-dev] [PATCH] crypto/cnxk: add PCI ID for cn9k Anoob Joseph
  2021-07-09  6:30 ` Akhil Goyal
@ 2021-07-09 12:09 ` David Marchand
  1 sibling, 0 replies; 3+ messages in thread
From: David Marchand @ 2021-07-09 12:09 UTC (permalink / raw)
  To: Anoob Joseph
  Cc: Akhil Goyal, Thomas Monjalon, Ali Alnubani, Jerin Jacob,
	Ankur Dwivedi, Tejasree Kondoj, dev

On Fri, Jul 9, 2021 at 8:29 AM Anoob Joseph <anoobj@marvell.com> wrote:
>
> Add PCI ID for crypo_cn9k PMD.
>
> To avoid conflicting PCI ID in crypto_octeontx2 and
> crypto_cn9k PMDs, disable crypto_cn9k PMD when built with
> octeontx2 config.
>
> The lack of PCI ID is causing debug build to fail for
> crypto_cn9k PMD.
>
> Reported-by: Ali Alnubani <alialnu@mellanox.com>
> Suggested-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>

Applied, thanks.


-- 
David Marchand


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2021-07-09 12:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-09  6:28 [dpdk-dev] [PATCH] crypto/cnxk: add PCI ID for cn9k Anoob Joseph
2021-07-09  6:30 ` Akhil Goyal
2021-07-09 12:09 ` David Marchand

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).