From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f47.google.com (mail-wm0-f47.google.com [74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 64A2137B4 for ; Fri, 2 Sep 2016 15:13:37 +0200 (CEST) Received: by mail-wm0-f47.google.com with SMTP id w2so29310119wmd.0 for ; Fri, 02 Sep 2016 06:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=JTOiMFS22iOsEejk4EYdhRNlxMhhXEgUBRs61uZcAus=; b=MdbeTtkA1UiyAEWScqrZNKfM9DIiR09n9b31gGGlHZbpW30WT1cI8EFMdp4jVs9YgC BQZuEMhwzltiSj9weCVwfwi7yGJDHbD2+4Wa/Lj4eDQlRX7c8yicF22Nv3F5McZPJlBd RdIl32ZPqx8Pz5mNF8D6PdN27P58YQSeXKJWUjlQJYazX8tzDub/YoSFiTh4n9tPdHR6 FrOvI4ztA9gA33Ld10jIycKJsC6VepfQJCWwbWhZ/QZ2+8GmdE52yk5sDp20WxLz+Vsf 3boDqCHiCtSzAceoNinMPEeKz0ZkFwepT25mLvOJbrvzv95WP9G/FjdhxLV7BEbFRb9z OH5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=JTOiMFS22iOsEejk4EYdhRNlxMhhXEgUBRs61uZcAus=; b=VQqMj1M2d+bEG2NaxuarXY5WXHFebJHn3xg/A3jiS81c8KlhhcR3KoLWx6/HzKP9tR lEPuvb9M1JFJMKnofD4HfVn4iQvPVJm7EunxqWAcpLZcWq8cdCjqpne7gYgYgCzNrhtY E88lJJnMlXwbqLNLFmdh7kU5o0YWZaD6Y3yhsX186p2HwQc8OxsaM/0vuhD0iJ5hivkO iaXqm4y8g7LKuKXh1k9CHrt+g67EhlR3crg8Z6uQnfD+X4YmovsrVpvEpepeuONr50wk T76MSnr3/GEbIYgl1VtKY2Oz9Ey6MzPt2dQQAvcLgQSgdbFrLn7tsctKrlaxUUFe/wdp 2Nlg== X-Gm-Message-State: AE9vXwMcfk0QOePqIWMdd5bkiXMDvgJn+NTrWxTnkZs7DvdA8GEgIjDhnEmdTbk6rCuCi1KM X-Received: by 10.28.47.7 with SMTP id v7mr3313784wmv.38.1472822017163; Fri, 02 Sep 2016 06:13:37 -0700 (PDT) Received: from xps13.localnet (184.203.134.77.rev.sfr.net. [77.134.203.184]) by smtp.gmail.com with ESMTPSA id q139sm3548220wmb.18.2016.09.02.06.13.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 02 Sep 2016 06:13:36 -0700 (PDT) From: Thomas Monjalon To: ASM Cc: dev@dpdk.org Date: Fri, 02 Sep 2016 15:13:35 +0200 Message-ID: <1628119.kfExARmFLF@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] Build with -Werror=declaration-after-statement X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Sep 2016 13:13:37 -0000 2016-09-02 13:49, ASM: > Hi folks! > > Many groups have flag -Werror=declaration-after-statement in the > their coding conventions. Dpdk have many code as static inline > function in the headers files and have trouble with it. > > For example: > * lib/librte_ether/rte_ether.h, function rte_vlan_strip > * lib/librte_eal/common/include/rte_dev.h, function rte_pmd_debug_trace > * lib/librte_eal/common/include/arch/x86/rte_spinlock.h, fucntion rte_try_tm > > Any project who use -Werror=declaration-after-statement can't to > compile own projects without > patching this headers. > > How do you look at to fix this problem? It is probably a good fix to have on top of Adrien's series: http://dpdk.org/ml/archives/dev/2016-July/043928.html You are welcome to fix any header to be more widely used :)