* [dpdk-dev] Build with -Werror=declaration-after-statement
@ 2016-09-02 10:49 ASM
2016-09-02 13:13 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: ASM @ 2016-09-02 10:49 UTC (permalink / raw)
To: dev
Hi folks!
Many groups have flag -Werror=declaration-after-statement in the
their coding conventions. Dpdk have many code as static inline
function in the headers files and have trouble with it.
For example:
* lib/librte_ether/rte_ether.h, function rte_vlan_strip
* lib/librte_eal/common/include/rte_dev.h, function rte_pmd_debug_trace
* lib/librte_eal/common/include/arch/x86/rte_spinlock.h, fucntion rte_try_tm
Any project who use -Werror=declaration-after-statement can't to
compile own projects without
patching this headers.
How do you look at to fix this problem?
---
Best regards,
Leonid Myravjev
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] Build with -Werror=declaration-after-statement
2016-09-02 10:49 [dpdk-dev] Build with -Werror=declaration-after-statement ASM
@ 2016-09-02 13:13 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2016-09-02 13:13 UTC (permalink / raw)
To: ASM; +Cc: dev
2016-09-02 13:49, ASM:
> Hi folks!
>
> Many groups have flag -Werror=declaration-after-statement in the
> their coding conventions. Dpdk have many code as static inline
> function in the headers files and have trouble with it.
>
> For example:
> * lib/librte_ether/rte_ether.h, function rte_vlan_strip
> * lib/librte_eal/common/include/rte_dev.h, function rte_pmd_debug_trace
> * lib/librte_eal/common/include/arch/x86/rte_spinlock.h, fucntion rte_try_tm
>
> Any project who use -Werror=declaration-after-statement can't to
> compile own projects without
> patching this headers.
>
> How do you look at to fix this problem?
It is probably a good fix to have on top of Adrien's series:
http://dpdk.org/ml/archives/dev/2016-July/043928.html
You are welcome to fix any header to be more widely used :)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-09-02 13:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-02 10:49 [dpdk-dev] Build with -Werror=declaration-after-statement ASM
2016-09-02 13:13 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).