From: Thomas Monjalon <thomas@monjalon.net>
To: Kathleen Capella <kathleen.capella@arm.com>
Cc: Wenzhuo Lu <wenzhuo.lu@intel.com>,
Beilei Xing <beilei.xing@intel.com>,
Bernard Iremonger <bernard.iremonger@intel.com>,
honnappa.nagarahalli@arm.com, dev@dpdk.org, nd@arm.com
Subject: Re: [dpdk-dev] [PATCH] testpmd: remove unused member from lcore structure
Date: Fri, 05 Feb 2021 21:11:10 +0100 [thread overview]
Message-ID: <16289590.gbtZyLo5GS@thomas> (raw)
In-Reply-To: <20210205190823.7765-1-kathleen.capella@arm.com>
About the title:
- the prefix should be app/testpmd
- it is not exactly an lcore structure
I would propose: app/testpmd: remove unused struct member
05/02/2021 20:08, Kathleen Capella:
> The tx_queue member of the fwd_lcore struct is unused as it is already
> part of the fwd_stream structure. Deleting helps improve code readability.
>
> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Thanks for looking at cleaning up.
prev parent reply other threads:[~2021-02-05 20:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-05 19:08 Kathleen Capella
2021-02-05 20:11 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16289590.gbtZyLo5GS@thomas \
--to=thomas@monjalon.net \
--cc=beilei.xing@intel.com \
--cc=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=honnappa.nagarahalli@arm.com \
--cc=kathleen.capella@arm.com \
--cc=nd@arm.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).