* [dpdk-dev] [PATCH] testpmd: remove unused member from lcore structure
@ 2021-02-05 19:08 Kathleen Capella
2021-02-05 20:11 ` Thomas Monjalon
0 siblings, 1 reply; 2+ messages in thread
From: Kathleen Capella @ 2021-02-05 19:08 UTC (permalink / raw)
To: Wenzhuo Lu, Beilei Xing, Bernard Iremonger
Cc: honnappa.nagarahalli, kathleen.capella, dev, nd
The tx_queue member of the fwd_lcore struct is unused as it is already
part of the fwd_stream structure. Deleting helps improve code readability.
Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
---
app/test-pmd/testpmd.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/app/test-pmd/testpmd.h b/app/test-pmd/testpmd.h
index 5f2316210..f805f1b4d 100644
--- a/app/test-pmd/testpmd.h
+++ b/app/test-pmd/testpmd.h
@@ -247,7 +247,6 @@ struct fwd_lcore {
streamid_t stream_idx; /**< index of 1st stream in "fwd_streams" */
streamid_t stream_nb; /**< number of streams in "fwd_streams" */
lcoreid_t cpuid_idx; /**< index of logical core in CPU id table */
- queueid_t tx_queue; /**< TX queue to send forwarded packets */
volatile char stopped; /**< stop forwarding when set */
};
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] testpmd: remove unused member from lcore structure
2021-02-05 19:08 [dpdk-dev] [PATCH] testpmd: remove unused member from lcore structure Kathleen Capella
@ 2021-02-05 20:11 ` Thomas Monjalon
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Monjalon @ 2021-02-05 20:11 UTC (permalink / raw)
To: Kathleen Capella
Cc: Wenzhuo Lu, Beilei Xing, Bernard Iremonger, honnappa.nagarahalli,
dev, nd
About the title:
- the prefix should be app/testpmd
- it is not exactly an lcore structure
I would propose: app/testpmd: remove unused struct member
05/02/2021 20:08, Kathleen Capella:
> The tx_queue member of the fwd_lcore struct is unused as it is already
> part of the fwd_stream structure. Deleting helps improve code readability.
>
> Signed-off-by: Kathleen Capella <kathleen.capella@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Acked-by: Thomas Monjalon <thomas@monjalon.net>
Thanks for looking at cleaning up.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-05 20:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-05 19:08 [dpdk-dev] [PATCH] testpmd: remove unused member from lcore structure Kathleen Capella
2021-02-05 20:11 ` Thomas Monjalon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).