From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9BA7A00C2; Fri, 24 Apr 2020 20:25:01 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 535071D523; Fri, 24 Apr 2020 20:25:00 +0200 (CEST) Received: from wout4-smtp.messagingengine.com (wout4-smtp.messagingengine.com [64.147.123.20]) by dpdk.org (Postfix) with ESMTP id AC9051D50A for <dev@dpdk.org>; Fri, 24 Apr 2020 20:24:58 +0200 (CEST) Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.west.internal (Postfix) with ESMTP id 2B45D187C; Fri, 24 Apr 2020 14:24:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute7.internal (MEProxy); Fri, 24 Apr 2020 14:24:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=fm1; bh= 56hrvQ2SRLSMsNU0hRPES8FgJdVs7qPaZmROaYdpdOM=; b=HNRlmrdToUvUhCFM b2V1phufXpGp3u5g5XvoR5M+9HCOO5zP2Krj6KuWlX8hj6pRVeXfYzxt8tI/gMyU zfQHF6JACvNDLT+D2S4CI9d9MbZhlKhztF/uw8SNlO2abB9/PdT0Xub+dMr6Zi4g s0bm5goV+29CIgDPsF0DaKkSc7Y7jiHG9852z/Qux24Xj0Vq88CArGU6rrJXFACn 7C+wMcYtS/F25HXypAPPf6NCJ6+07T/C24SGNGbHrOfrzrwSZ+f9SvZGdo1B0q/R ECulqbUqk4RJvSzASRxGsiFQ3yG8hiDolFW+2L1cPA84NmQVce6BOgvwfyQCNSj3 64BvOQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=56hrvQ2SRLSMsNU0hRPES8FgJdVs7qPaZmROaYdpd OM=; b=ZTI3Bp6tKm5TYKnMP+Ti5KdEuKtI4SGcyj4AHUQRMz+4HaABAYtk5Cdj0 A7yB5odC/n0oSI+ejjV1KWyVU5VWe06BGMvO8Ajs6sM06jU4bwLXlqP3RgaxDFCF eaA6zNBYMpe+xYoNB4gsdlq03umne1hvc9buVWsEyo3ZdNEHqZSC2bzWgLLnHPl2 MyBNk/7ez0kP+7R8yXgl7kjiG/y/YcGntlLtGVJAVG7Av9VUZV/KBm0OM67slo4v zxLFa5eUVQ40IkXtJwrtCEfb7FyLe8XNBIC9b4Lnjbsk6zhvSaB3if5/+OMVv+uj 3x+W8xwKj6wOAOn4h6yyrTklLYCVg== X-ME-Sender: <xms:9i6jXl7GYVcyWog0W7L0y1XzNzspCPNvjRrmi_SI5Ay7cuu735vXJA> X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduhedrhedugdduudelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecukf hppeejjedrudefgedrvddtfedrudekgeenucevlhhushhtvghrufhiiigvpedtnecurfgr rhgrmhepmhgrihhlfhhrohhmpehthhhomhgrshesmhhonhhjrghlohhnrdhnvght X-ME-Proxy: <xmx:9i6jXrC7gJp9d66jQ8b6vwb-RIrob8f57KsGbjnTPV83NsT8hoA02g> <xmx:9i6jXr8XSeEM8uQ3SNmxBqt2FKfCvCVlvRup-tHUlW8b5YMMKfXu1A> <xmx:9i6jXuE082_p5oQumTf0K0LGNP_zFsWcFCJEVflEL9Y3-rqSfLj5zQ> <xmx:9y6jXj6t602tiF3X0_A2cjUhlt7w5p_S54ovhyJlYkf-jlC0GDoRQQ> Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 30B643065DB0; Fri, 24 Apr 2020 14:24:54 -0400 (EDT) From: Thomas Monjalon <thomas@monjalon.net> To: Somnath Kotur <somnath.kotur@broadcom.com> Cc: Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org, Ferruh Yigit <ferruh.yigit@intel.com>, Stephen Hemminger <stephen@networkplumber.org> Date: Fri, 24 Apr 2020 20:24:53 +0200 Message-ID: <1629576.oqx4rD5t72@thomas> In-Reply-To: <20200225165541.01c06952@hermes.lan> References: <20200106083423.26600-1-somnath.kotur@broadcom.com> <20200207142959.GR22738@platinum> <20200225165541.01c06952@hermes.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] mbuf: fix to update documentation of QinQ stripped bit interpretation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Please Somnath, it is waiting for a v2. 26/02/2020 01:55, Stephen Hemminger: > On Fri, 7 Feb 2020 15:29:59 +0100 > Olivier Matz <olivier.matz@6wind.com> wrote: > > > The meaning of each flag should be as simple as possible, I think we can > > summarize them like this: > > > > - PKT_RX_VLAN: the vlan is saved in vlan tci. > > - PKT_RX_VLAN_STRIPPED: the vlan hdr is removed from packet data. > > - PKT_RX_QINQ: the outer vlan is saved in vlan tci. > > - PKT_RX_QINQ_STRIPPED: the inner vlan is stripped from packet data. > > - When PKT_RX_QINQ is set, PKT_RX_VLAN* refer to the inner vlan > > of initial packet, else it refers to the first vlan of the packet. > > > > There is a link between vlan flag and vlan_tci field, and qinq flag and > > vlan_tci_outer field. > > > > I'm still not sure to understand what you expect. Can you give an > > example with flags (which are set), and the expected content of m->vlan_tci > > and m->vlan_tci_outer? > > > > By the way, the case 5/ is not very well described too, maybe we should > > add something about it. > > > > Thanks, > > Olivier > > The patch does help clarify the meaning, and Oliver's summary clarifies > even more. It might be possible for hardware to offload inner vlan but > not outer vlan, though seriously doubt anyone but some conformance test > would do that.