From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id 8E5991E2F for ; Wed, 2 Nov 2016 15:08:06 +0100 (CET) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga103.fm.intel.com with ESMTP; 02 Nov 2016 07:05:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,583,1473145200"; d="scan'208";a="1062870174" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.57]) ([10.237.220.57]) by fmsmga001.fm.intel.com with ESMTP; 02 Nov 2016 07:05:41 -0700 To: Mauricio Vasquez B , bruce.richardson@intel.com References: <1478030140-7127-1-git-send-email-mauricio.vasquez@polito.it> <1478094369-3943-1-git-send-email-mauricio.vasquez@polito.it> From: Ferruh Yigit Message-ID: <162c0602-5fff-fa80-98c5-3725fcb96e69@intel.com> Date: Wed, 2 Nov 2016 14:05:40 +0000 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1478094369-3943-1-git-send-email-mauricio.vasquez@polito.it> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH v3] net/ring: remove unnecessary NULL check X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Nov 2016 14:08:08 -0000 On 11/2/2016 1:46 PM, Mauricio Vasquez B wrote: > Coverity detected this as an issue because internals->data will never be NULL, > then the check is not necessary. > > Fixes: d082c0395bf6 ("ring: fix memory leak when detaching") > Coverity issue: 137873 > > Signed-off-by: Mauricio Vasquez B > --- Acked-by: Ferruh Yigit