From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by dpdk.org (Postfix) with ESMTP id ECF435591 for ; Fri, 11 Nov 2016 10:29:44 +0100 (CET) Received: by mail-wm0-f54.google.com with SMTP id a197so414964239wmd.0 for ; Fri, 11 Nov 2016 01:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:user-agent:in-reply-to :references:mime-version:content-transfer-encoding; bh=erCE/kVZemEzvxQOlwyEzAZEA2tewGwvt8bCF41Cx6s=; b=kPnyj3OAYwwqKrfaOnp60O0v/fp3mVPktZFd1mt02XYJPFxkGbphx5Dnte0ZCAVELx Ey23Q8nPvXjUzfYArR7R7lYRlzWN8dxn5JDizHTuHJf/g5iNIlfwfeRo3n2d9YhpLlkX oH2fehwKgI9/dq1tqYmFUgp5sH80X130xxjh3wUxONaF1fE7sJLEn6kBXM8EYbkDZbkU QrMO4RfcU7lVcWPZCZmVZhCocGf2PNulfjVVJj3Zpu82gFCpZI78YahjUIkmOSunJM7D v5G5/PxVWorjycaRfuekCkR87p7QnNUOm9BT5U78SS9jtpKee0GADRzAHTRSTY9ou+Gg aYAw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:user-agent :in-reply-to:references:mime-version:content-transfer-encoding; bh=erCE/kVZemEzvxQOlwyEzAZEA2tewGwvt8bCF41Cx6s=; b=bQIjo0MsklHAgNxyHBkxAaFM0tClp4ghRPeWZlqw5jwcl9+SrTBThdGuu0xjKVJ8Z/ Yq4n4numNWdm+06yyCiby7tm7TavDSB92VLSUyP0lhqWQLN5Bocnz5X0w4zUIgY7whpL tEor6rNtqLbPgFTqvHFd8vx9m1FxaD7LlXNONRldgtskK8YwokDmnv4eZLGmGqPqRgIS LlWd9OSX+Rl81WMx+JaIKHil1In0WJ3Lht4wRJDQ+9I7G2MYxiPNzRS+dfJKQV/oNmTo N3lm9hqm+e3zz0ssDfNDt63NApdLjg+Ka5EnfoY4B5YGlKh6nEd/IcRjeVyd70O9tYf7 6uxA== X-Gm-Message-State: ABUngvdSJ7cc3i71G98ynl2xYoM9xC/M9jdTAghTZzKt7V5tHhLSe17hXhW83zCyjcO0K0DH X-Received: by 10.28.134.146 with SMTP id i140mr3901008wmd.100.1478856584608; Fri, 11 Nov 2016 01:29:44 -0800 (PST) Received: from xps13.localnet (103.114.118.80.rev.sfr.net. [80.118.114.103]) by smtp.gmail.com with ESMTPSA id c187sm11060606wmd.13.2016.11.11.01.29.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Nov 2016 01:29:43 -0800 (PST) From: Thomas Monjalon To: Alejandro Lucero Cc: dev@dpdk.org, Bert van Leeuwen Date: Fri, 11 Nov 2016 10:29:42 +0100 Message-ID: <1630834.YGmmObtqnA@xps13> User-Agent: KMail/4.14.10 (Linux/4.5.4-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: References: <1478786449-44745-1-git-send-email-alejandro.lucero@netronome.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] ethdev: check number of queues less than RTE_ETHDEV_QUEUE_STAT_CNTRS X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 09:29:46 -0000 2016-11-11 09:16, Alejandro Lucero: > Thomas, > > We are wondering if you realize this patch fixes a bug with current ethdev > code as a device can have more than RTE_ETHDEV_QUEUE_STAT_CNTRS. > > Maybe the commit message is giving the wrong impression and as you > commented, it should just focus on the bug it fixes and to leave for > another email thread the discussion of how to solve the > RTE_ETHDEV_QUEUE_STAT_CNTRS > problem. > > Should we remove this from patchwork and to send another patch that way? Yes please. It was my first comment, we don't understand the exact issue you are fixing. And I have a bad feeling it could break something else (really just a feeling). It is not the kind of patch we can apply the last day of a release. That's why I think it should wait 17.02. Of course you can try to convince me and others to apply it as a last minute patch. But why are you sending a patch on the generic API in the last days? Last argument: it is not fixing a regression of 16.11, so it is not so urgent.