Re: [dpdk-dev] [PATCH v5] app/test: fix build when ring PMD is disabled

[Thomas Monjalon <thomas@monjalon.net>]

20/01/2020 18:36, Bruce Richardson:
> On Mon, Dec 23, 2019 at 06:53:05AM +0000, Reshma Pattan wrote:
> > Some unit tests has dependency on RING PMD,
> > so this patch is trying to fix those and other
> > closely related issues.
> > 
> > 1)pdump, latency, bitrate, ring PMD and test_event_eth_tx_adapter
> > unit tests are dependent on ring PMD, so compile those
> > tests only when ring PMD is enabled else ignore.
> > 
> > 2)get rid of make file error which was added by bond unit test
> > for ring PMD disabled case which is not necessary.
> > 
> > 3)Tx adapter UT is dependent on RING PMD, but it was
> > observed that it was missing from the run in meson
> > build, so added it. TX adapter UT uses 'sw event and
> > 'null' pmd drivers, so for shared builds the drivers .so
> > path has to be passed to the test args of meson UT run.
> > 
> > Fixes: 086eb64db3 ("test/pdump: add unit test for pdump library")
> > Fixes: fdeb30fa71 ("test/bitrate: add unit tests for bitrate library")
> > Fixes: 1e3676a06e ("test/latency: add unit tests for latencystats library")
> > Fixes: 46cf97e4bb ("eventdev: add test for eth Tx adapter")
> > Fixes: d23e09e0ef ("app/test: link with ring pmd when needed")
> > 
> > CC: stable@dpdk.org
> > CC: Nikhil Rao <nikhil.rao@intel.com>
> > CC: Chas Williams <chas3@att.com>
> > CC: Bruce Richardson <bruce.richardson@intel.com>
> > CC: Stephen Hemminger <stephen@networkplumber.org>
> > 
> > Reported-by: Stephen Hemminger <stephen@networkplumber.org>
> > Signed-off-by: Reshma Pattan <reshma.pattan@intel.com>
> > ---
> > v5: remove extra blank line.
> > v4: fix event_eth_tx_adapter_autotest for shared build
> > as reported by travis-ci
> > https://travis-ci.com/ovsrobot/dpdk/jobs/249598391
> > v3: add missing test event_eth_tx_adapter_autotest.
> > Add link bonding mode4 test to drivers test.
> > v2: fix comments of v1 and combine the patches 1/2 and 2/2 of v1
> > ---
> 
> Confirmed build now works with disable_drivers=net/ring
> 
> Tested-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks

> Unfortunately, other parts fail if other drivers are similarly disabled,
> but that is for another patchset (and probably release!) to fix.

Good to know we are far from retirement ;)