From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 6E9637EC7 for ; Wed, 1 Aug 2018 16:22:59 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 0A71121785; Wed, 1 Aug 2018 10:22:59 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Wed, 01 Aug 2018 10:22:59 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-sender :x-me-sender:x-sasl-enc; s=mesmtp; bh=g8rEB/owEWeF7wHqTK9cvoOGsS J2eLtc4RYADwE7KQU=; b=ltM5QVtK0Uer3s1RkQyC9Xs4gqJBnEnHz8g93MfdQW frNhMDqDorWF4c2lG+NwExtBfJm0kHD1a2ZW/+qN7Bf1ivaKs3tG6z/uYKwdfQRc KaFsBRDft5TyWclyeDV0+W9gGf1iCBAD8eB0pOdoN/7LXdRNLkvebto+/WTaPrbP M= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=g8rEB/ owEWeF7wHqTK9cvoOGsSJ2eLtc4RYADwE7KQU=; b=aNNjOZSJz3LDKWZZ7eJfle zf437CkmOd6IaxwSeKAzb9+LWY+sAIhZSqS6yFMfC83/0m6BBQawhbS9HJXPshAV rXu1iNZEbuiZjNAVvJI5hhVLBveSRwD4MJCva00v3q2sEQYdyipm9sNRn5Ni8FMW rRumPJgjcqLUF3xncty0Fl1t7r+8JYvk+WxWXTebrFqeXl9/r1LzFqGaILCKRb12 Ues2DE++leHnbBR6rdU47v7Tl2vGLTctUbXzY1bajAwuKzOeKdyRCYD3qeGY4VXZ 6Kou2224Qj7xVbNVrLN1Ykx1kktSMuQF7uUTOCH+a+NqWwxPOWT89oLQS/272OFQ == X-ME-Proxy: X-ME-Sender: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id D018A10268; Wed, 1 Aug 2018 10:22:57 -0400 (EDT) From: Thomas Monjalon To: Bernard Iremonger Cc: dev@dpdk.org, Andrew Rybchenko , ferruh.yigit@intel.com, allain.legacy@windriver.com Date: Wed, 01 Aug 2018 16:22:53 +0200 Message-ID: <1631329.C8Q0lmT8f5@xps> In-Reply-To: <239fdbf4-dd8f-97c7-58d6-dfaefb28fe3d@solarflare.com> References: <1533111199-4621-1-git-send-email-bernard.iremonger@intel.com> <239fdbf4-dd8f-97c7-58d6-dfaefb28fe3d@solarflare.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] app/testpmd: set and clear keep CRC offload flag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Aug 2018 14:22:59 -0000 01/08/2018 10:22, Andrew Rybchenko: > On 01.08.2018 11:13, Bernard Iremonger wrote: > > If the "port config all crc-strip on" command is issued, > > The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be cleared. > > > > If the "port config all crc-strip off command is issued, > > The DEV_RX_OFFLOAD_KEEP_CRC offload flag should be set. > > > > Fixes: 70815c9ecadd ("ethdev: add new offload flag to keep CRC") > > Signed-off-by: Bernard Iremonger > > Acked-by: Andrew Rybchenko Applied, thanks