From: Thomas Monjalon <thomas@monjalon.net>
To: Roy Franz <roy.franz@cavium.com>
Cc: dev@dpdk.org, "Mcnamara, John" <john.mcnamara@intel.com>,
Roy Franz <rfranz@cavium.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] doc: Fix typo
Date: Thu, 11 Jan 2018 18:37:45 +0100 [thread overview]
Message-ID: <1631509.VzlvQJyhOh@xps> (raw)
In-Reply-To: <B27915DBBA3421428155699D51E4CFE23EE201DC@IRSMSX103.ger.corp.intel.com>
11/12/2017 16:20, Mcnamara, John:
> > Fix trivial typo (an -> and) in description of service core masks.
> >
> > Signed-off-by: Roy Franz <roy.franz@cavium.com>
>
> Thanks. For future reference the subject line should be lowercase like:
>
> doc: fix typo
>
> Or better
>
> doc: fix typo in service cores doc
Better to use "guide" when fixing a guide:
doc: fix typo in prog guide
> See: http://dpdk.org/doc/guides/contributing/patches.html#commit-messages-subject-line
>
> Apart from that,
>
> Acked-by: John McNamara <john.mcnamara@intel.com>
Series applied, thanks
next prev parent reply other threads:[~2018-01-11 17:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 18:26 [dpdk-dev] [PATCH 1/2] doc: Clarify wording regarding actions and flow rules Roy Franz
2017-12-01 18:26 ` [dpdk-dev] [PATCH 2/2] doc: Fix typo Roy Franz
2017-12-11 15:20 ` Mcnamara, John
2018-01-11 17:37 ` Thomas Monjalon [this message]
2017-12-04 13:51 ` [dpdk-dev] [PATCH 1/2] doc: Clarify wording regarding actions and flow rules Adrien Mazarguil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1631509.VzlvQJyhOh@xps \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=john.mcnamara@intel.com \
--cc=rfranz@cavium.com \
--cc=roy.franz@cavium.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).