From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5F17AA00E6 for ; Thu, 8 Aug 2019 12:22:07 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 52D171B9D9; Thu, 8 Aug 2019 12:22:06 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id A27091B9CD for ; Thu, 8 Aug 2019 12:22:04 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id D186C21EBC; Thu, 8 Aug 2019 06:22:03 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute1.internal (MEProxy); Thu, 08 Aug 2019 06:22:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=d5OnIVM4unOq0Cl+9NXnSd7dWHMsekMUsz7F7os3zDw=; b=sIRz9Ijxnc77 1rbPhD6LC8WpayjRqflh+Wt/gK2QSb3enkmLVua9EvT/hgpxbUKmK+NfBXocXckO mPy3rvUbaN3Xx5yNl+f9A5eQX0WI/dbSW8FYTJIwADKrxWCZOVjIimdf3dqaR/4s yIqL37JkUsf7VmAqlX0pxY2k48wSbuw= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=d5OnIVM4unOq0Cl+9NXnSd7dWHMsekMUsz7F7os3z Dw=; b=kHoSwTkitbLpbk8J9kIHObaeLXDB73gr4apN6JGIFJ6EpRsznGaPK7v48 7bBHihP1gILHz2MwGVts5b74U9ccpY3hLUOWdQ33dsJL/fIXuhQsxLKYX1jG2oWZ mVd8LR/PJveL7Z0KLrabr8gIjVCJC1Q6VZ4reL/U5uAOwSyZhyxH6cuEVOm3AM9m jGan7uc8KFUQz2ATfn8l33epNUOLVo9sSDWZRXyzjoTJUSOKzF7FBVppv0PZEi6H W+CUIMJ/L1tdqv4DcMNjTVcKcVlHzeZm5dmw4r7G7ydRtAFu2doSzZxBaj+s/HQB UYGSH+Hx0HNxfn/F1SxiEKrQ7Blsw== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudduhedgvdekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhephffvufffkfgjfhgggfgtsehtufertddttddvnecuhfhrohhmpefvhhhomhgr shcuofhonhhjrghlohhnuceothhhohhmrghssehmohhnjhgrlhhonhdrnhgvtheqnecuff homhgrihhnpehhuhgrrhhmrdgtohhmnecukfhppeelfedriedrudegledruddugeenucfr rghrrghmpehmrghilhhfrhhomhepthhhohhmrghssehmohhnjhgrlhhonhdrnhgvthenuc evlhhushhtvghrufhiiigvpedt X-ME-Proxy: Received: from xps.localnet (114.149.6.93.rev.sfr.net [93.6.149.114]) by mail.messagingengine.com (Postfix) with ESMTPA id 6C50F380088; Thu, 8 Aug 2019 06:22:02 -0400 (EDT) From: Thomas Monjalon To: Aaron Conole Cc: dev@dpdk.org, "Phil Yang (Arm Technology China)" , "Gavin Hu (Arm Technology China)" , Honnappa Nagarahalli , nd Date: Thu, 08 Aug 2019 12:22:00 +0200 Message-ID: <16315833.7BtyHD5jhk@xps> In-Reply-To: References: <20190807145844.23670-1-aconole@redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [PATCH] test/mcslock: wait for lcore completion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 08/08/2019 05:44, Phil Yang (Arm Technology China): > From: Aaron Conole > > > > It's possible that the mcsunlock occurs before the test_mcslock_try has > > a chance to execute, which will result in the trylock being successful, > > making the test case fail. Fix this by waiting until all lcores have > > completed their test before unlocking the master lock. > > > > Fixes: 32dcb9fd2a22 ("test/mcslock: add MCS queued lock unit test") > > Cc: Phil Yang > > Cc: Gavin Hu > > Cc: Honnappa Nagarahalli > > Signed-off-by: Aaron Conole > > Thanks for the patch. > Acked-by: Phil Yang Applied, thanks