From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by dpdk.org (Postfix) with ESMTP id D505456A9 for ; Thu, 11 Feb 2016 12:52:28 +0100 (CET) Received: by mail-wm0-f49.google.com with SMTP id g62so17795291wme.0 for ; Thu, 11 Feb 2016 03:52:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=6wind-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:organization:user-agent :in-reply-to:references:mime-version:content-transfer-encoding :content-type; bh=yuqYGap1NFaGUQIDbPK9/8rFUloJJnu1DldlMkFfl5E=; b=PFkvUC9F4Vlx/52w03wOgJttZRqZQtEieE8ig1i6GzjCRqjhy/u9/HHlRdcXHLjdSa ge04QKkOIisrSkRUG7nUHSFjUOQFFy/KiXfppLMmFkyOCrarJ0uM4nQpIoDdr0j9hHwq aD7AE1+GUgnAJrtObg1ZGiKBYcri6vzTY0GxNmZPfICn2n00UORI7tuiQkAMUGDDGNwr BuGJ91YXH6WYnJe/P3cT9DzhdHpkPeuW2cvSrbIuwp5n6nZSl1Fh/lSmbx1T1AV7Lx6q uHcMOzNL/fB/XOnBbLlwcKneE0SWbzCNpFoyD28LI8IrXwSCsJGBXrdpS0Udf6Z5j6oX dXgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:date:from:to:cc:subject:message-id:organization :user-agent:in-reply-to:references:mime-version :content-transfer-encoding:content-type; bh=yuqYGap1NFaGUQIDbPK9/8rFUloJJnu1DldlMkFfl5E=; b=Sn0e9xwdrSIjQ5m1t8P5OXPOEd22WG7uZBhlJXGZWgxPsHhTZzkGTNb6ALZ+xyav0H 649hfHWXdlr2lgQ/NMn9ppi44UXMYDWK2jjrEMK7/oItA6483tUOKQr+ZZsIWIajgsno MNf8ZpWwrabeLVQSuhUMf5YfUArOwnF7Npza+5ezxpYrrqMOL4A8NbnQ3+5rejascHGZ SFkCzfJYkjiybdCP+o95G7Z4W2Sxh7zxtyRtuFbuE24oFOoRBDljWYPCPk3zVfZhWRY8 awvCHBj8ZTJNQR6oFLkxOAUzZ42Aw61t+mn59jIvChtpo2WLG36EEcHIQ+zBnAGBKsl0 8/CQ== X-Gm-Message-State: AG10YOSwt1jc7rqOpz2ZBVuxDfoCXtAb4yMCRRdPsgFSNMHmD1X7h9ev+TQlv8atEGbJg3jN X-Received: by 10.28.129.194 with SMTP id c185mr17390346wmd.29.1455191548664; Thu, 11 Feb 2016 03:52:28 -0800 (PST) Received: from xps13.localnet (136-92-190-109.dsl.ovh.fr. [109.190.92.136]) by smtp.gmail.com with ESMTPSA id g126sm11355985wmf.16.2016.02.11.03.52.27 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 11 Feb 2016 03:52:28 -0800 (PST) Date: Thu, 11 Feb 2016 03:52:28 -0800 (PST) X-Google-Original-Date: Thu, 11 Feb 2016 12:51 +0100 From: Thomas Monjalon To: Jerin Jacob Message-ID: <1632085.ioBsreKaWO@xps13> Organization: 6WIND User-Agent: KMail/4.14.10 (Linux/4.1.6-1-ARCH; KDE/4.14.11; x86_64; ; ) In-Reply-To: <2977549.PxuGhIR2Yb@xps13> References: <1449498170-19872-1-git-send-email-jerin.jacob@caviumnetworks.com> <20151208093333.GA3650@localhost.localdomain> <2977549.PxuGhIR2Yb@xps13> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Cc: dev@dpdk.org, viktorin@rehivetech.com Subject: Re: [dpdk-dev] [PATCH] config: cleanup existing RTE_CACHE_LINE_SIZE selection scheme X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Feb 2016 11:52:29 -0000 2016-02-08 12:44, Thomas Monjalon: > 2015-12-08 15:03, Jerin Jacob: > > On Mon, Dec 07, 2015 at 03:45:10PM +0100, Thomas Monjalon wrote: > > > 2015-12-07 19:52, Jerin Jacob: > > > > by default, all the targets will be configured with the 64-byte cache line > > > > size, targets which have different cache line size can be overridden > > > > through target specific config file. > > > > > > > > Selected ThunderX and power8 as CONFIG_RTE_CACHE_LINE_SIZE=128 targets > > > > based on existing configuration. > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > It looks good. > > > We are moving from a constant defined on CC command line in most cases > > > to a constant included in rte_config.h only. > > > Have you checked that the generated libraries are identical? > > > > Yes, Tested with a 64byte(x86_64-native-linuxapp-gcc) and a 128byte > > (arm64-thunderx-linuxapp-gcc) target. > > md5sum build/app/test comes same with or without patch. > > > > > It would be good to have a check for POWER8. Chao? > > > Thanks > > It seems we won't have a test on POWER8. > > Acked-by: Thomas Monjalon Applied, thanks