From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: "liufengjiang.0426" <liufengjiang.0426@bytedance.com>, dev@dpdk.org
Cc: chenbo.xia@intel.com, zhangziqian.1@bytedance.com
Subject: Re: [PATCH v2] net/virtio: fixed missing next flag when sending packets in packed mode
Date: Tue, 10 Oct 2023 09:12:37 +0200 [thread overview]
Message-ID: <16321d7a-ee73-c1bf-4818-2d6553d066d1@redhat.com> (raw)
In-Reply-To: <20231010020828.2128-1-liufengjiang.0426@bytedance.com>
Hi,
Thanks for investigating the issue and proposing a fix!
On 10/10/23 04:08, liufengjiang.0426 wrote:
> When the packets is sent in packed mode, and the packets data and
> virtio-header are divided into two desc, set the next flag of
> virtio-header desc
>
>>> Fix the warning that a single line of commit log exceeds 75 chars
The changelog should not be part of the commit message.
>
> Bugzilla ID: 1295
> Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues")
>
> Signed-off-by: liufengjiang.0426 <liufengjiang.0426@bytedance.com>
Could you please sign-off with your full name?
> ---
The changelog should be placed here.
> drivers/net/virtio/virtqueue.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h
> index 9d4aba11a3..4e9f2d0358 100644
> --- a/drivers/net/virtio/virtqueue.h
> +++ b/drivers/net/virtio/virtqueue.h
> @@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie,
> */
> start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr);
> start_dp[idx].len = vq->hw->vtnet_hdr_size;
> + head_flags |= VRING_DESC_F_NEXT;
> hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr;
> idx++;
> if (idx >= vq->vq_nentries) {
Otherwise, the fix look good to me.
With above small changes, it will be good for me.
Thanks,
Maxime
next prev parent reply other threads:[~2023-10-10 7:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-09 13:06 [PATCH] " liufengjiang.0426
2023-10-10 2:08 ` [PATCH v2] " liufengjiang.0426
2023-10-10 7:12 ` Maxime Coquelin [this message]
2023-10-12 13:56 ` Maxime Coquelin
2023-10-17 6:01 ` [PATCH] " liufengjiang.0426
2023-10-17 7:04 ` Fengjiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16321d7a-ee73-c1bf-4818-2d6553d066d1@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=chenbo.xia@intel.com \
--cc=dev@dpdk.org \
--cc=liufengjiang.0426@bytedance.com \
--cc=zhangziqian.1@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).