From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D6E3F42348; Tue, 10 Oct 2023 09:12:45 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A4C67402CB; Tue, 10 Oct 2023 09:12:45 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4EA8D4029F for ; Tue, 10 Oct 2023 09:12:44 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1696921963; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=YJ9Ouz7NQcSAIMS23Sfn8duf3Al/ZwY1kT+FSiWouQA=; b=jITgUVdacfFm2uG3QXXbDfGJ0VkPzgjQFWpYhadDKOE13e2KgTWAsGw0OE2MyNuAlWwK4O M33aXFqQlV8n94fWhYpZUIerz/3KRleV6UAAcypai40Y4r05soTM/NI33CM5DqG0WXqqbb wJ25jRS6+I0MuDhi0fochmGkq2bZa8w= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-583-OlXvX4dDNXSCZZqv6nEPHw-1; Tue, 10 Oct 2023 03:12:40 -0400 X-MC-Unique: OlXvX4dDNXSCZZqv6nEPHw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 2F539185A79B; Tue, 10 Oct 2023 07:12:40 +0000 (UTC) Received: from [10.39.208.11] (unknown [10.39.208.11]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 47ED31B9C; Tue, 10 Oct 2023 07:12:38 +0000 (UTC) Message-ID: <16321d7a-ee73-c1bf-4818-2d6553d066d1@redhat.com> Date: Tue, 10 Oct 2023 09:12:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2] net/virtio: fixed missing next flag when sending packets in packed mode To: "liufengjiang.0426" , dev@dpdk.org Cc: chenbo.xia@intel.com, zhangziqian.1@bytedance.com References: <20231009130609.2987-1-liufengjiang.0426@bytedance.com> <20231010020828.2128-1-liufengjiang.0426@bytedance.com> From: Maxime Coquelin In-Reply-To: <20231010020828.2128-1-liufengjiang.0426@bytedance.com> X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hi, Thanks for investigating the issue and proposing a fix! On 10/10/23 04:08, liufengjiang.0426 wrote: > When the packets is sent in packed mode, and the packets data and > virtio-header are divided into two desc, set the next flag of > virtio-header desc > >>> Fix the warning that a single line of commit log exceeds 75 chars The changelog should not be part of the commit message. > > Bugzilla ID: 1295 > Fixes: 892dc798fa9c ("net/virtio: implement Tx path for packed queues") > > Signed-off-by: liufengjiang.0426 Could you please sign-off with your full name? > --- The changelog should be placed here. > drivers/net/virtio/virtqueue.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/virtio/virtqueue.h b/drivers/net/virtio/virtqueue.h > index 9d4aba11a3..4e9f2d0358 100644 > --- a/drivers/net/virtio/virtqueue.h > +++ b/drivers/net/virtio/virtqueue.h > @@ -672,6 +672,7 @@ virtqueue_enqueue_xmit_packed(struct virtnet_tx *txvq, struct rte_mbuf *cookie, > */ > start_dp[idx].addr = txvq->hdr_mem + RTE_PTR_DIFF(&txr[idx].tx_hdr, txr); > start_dp[idx].len = vq->hw->vtnet_hdr_size; > + head_flags |= VRING_DESC_F_NEXT; > hdr = (struct virtio_net_hdr *)&txr[idx].tx_hdr; > idx++; > if (idx >= vq->vq_nentries) { Otherwise, the fix look good to me. With above small changes, it will be good for me. Thanks, Maxime